Skip to content

[java] added example how to use requireDownloadsEnabled method #14918

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 4 commits into from
Closed

[java] added example how to use requireDownloadsEnabled method #14918

Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
7d6d36f
added example how to use requireDownloadsEnabled method
iampopovich Dec 19, 2024
98c44dc
applied formatting
iampopovich Dec 19, 2024
77f0f06
Merge branch 'trunk' into javadoc-fixes
iampopovich Dec 19, 2024
c06a761
set example with ChromeOptions
iampopovich Dec 19, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 7 additions & 1 deletion java/src/org/openqa/selenium/HasDownloads.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -27,7 +27,13 @@ public interface HasDownloads {
/**
* Requires downloads to be enabled.
*
* <p>TODO: Create an example in the documentation and provide a link to it.
* <p>Example usage:
*
* <pre>{@code
* ChromeOptions options = new ChromeOptions();
* options.setCapability("se:downloadsEnabled", true);
* driver.requireDownloadsEnabled(options);
* }</pre>
Comment on lines +30 to +36
Copy link
Member

@diemol diemol Dec 23, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

What was meant by "Create an example in the documentation and provide a link to it.", was to create a code example in the documentation repository and point to it.

So the JavaDoc should have a phrase pointing to https://www.selenium.dev/documentation/webdriver/drivers/remote_webdriver/#downloads.

Copy link
Contributor Author

@iampopovich iampopovich Dec 23, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@diemol thanks for your advice 🙏
I'll finish it later this week

*
* @param capabilities the capabilities object
* @throws WebDriverException if capability to enable downloads is not set
Expand Down