Skip to content

[bidi][java] Add test to add a cookie in a user context #15312

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Mar 25, 2025
Merged

[bidi][java] Add test to add a cookie in a user context #15312

Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
eb61fa1
[bidi][java] Add test to add a cookie in a user context
pujagani Feb 20, 2025
d4336c4
Merge branch 'trunk' into add-test-usercontext-cookie
pujagani Mar 20, 2025
e524281
Merge branch 'trunk' into add-test-usercontext-cookie
pujagani Mar 25, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
56 changes: 54 additions & 2 deletions java/test/org/openqa/selenium/bidi/storage/StorageCommandsTest.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -30,6 +30,9 @@
import org.openqa.selenium.Cookie;
import org.openqa.selenium.JavascriptExecutor;
import org.openqa.selenium.WindowType;
import org.openqa.selenium.bidi.browsingcontext.BrowsingContext;
import org.openqa.selenium.bidi.browsingcontext.CreateContextParameters;
import org.openqa.selenium.bidi.module.Browser;
import org.openqa.selenium.bidi.module.Storage;
import org.openqa.selenium.bidi.network.BytesValue;
import org.openqa.selenium.testing.JupiterTestBase;
Expand Down Expand Up @@ -121,8 +124,57 @@ public void canGetCookieInDefaultUserContext() {
}

@Test
// TODO: Once Browser module is added this test needs to be added
public void canGetCookieInAUserContext() {}
@NotYetImplemented(EDGE)
public void canGetCookieInAUserContext() {
Browser browser = new Browser(driver);
String userContext = browser.createUserContext();
String windowHandle = driver.getWindowHandle();

String key = generateUniqueKey();
String value = "set";

PartitionDescriptor descriptor = new StorageKeyPartitionDescriptor().userContext(userContext);

SetCookieParameters parameters =
new SetCookieParameters(
new PartialCookie(
key, new BytesValue(BytesValue.Type.STRING, value), appServer.getHostName()),
descriptor);

storage.setCookie(parameters);

CookieFilter cookieFilter = new CookieFilter();
cookieFilter.name(key);
cookieFilter.value(new BytesValue(BytesValue.Type.STRING, "set"));

BrowsingContext context =
new BrowsingContext(
driver, new CreateContextParameters(WindowType.TAB).userContext(userContext));

driver.switchTo().window(context.getId());

GetCookiesParameters params = new GetCookiesParameters(cookieFilter, descriptor);

GetCookiesResult result = storage.getCookies(params);

assertThat(result.getCookies().get(0).getValue().getValue()).isEqualTo(value);
PartitionKey partitionKey = result.getPartitionKey();

assertThat(partitionKey.getUserContext()).isNotNull();
assertThat(partitionKey.getUserContext()).isEqualTo(userContext);

driver.switchTo().window(windowHandle);

PartitionDescriptor browsingContextPartitionDescriptor =
new BrowsingContextPartitionDescriptor(windowHandle);

GetCookiesParameters params1 =
new GetCookiesParameters(cookieFilter, browsingContextPartitionDescriptor);

GetCookiesResult result1 = storage.getCookies(params1);

assertThat(result1.getCookies().size()).isEqualTo(0);
}

@Test
@NotYetImplemented(EDGE)
Expand Down
Loading