Skip to content

[dotnet] Remove #nullable enable from CDP-generated types #15388

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 1 commit into from
Closed

[dotnet] Remove #nullable enable from CDP-generated types #15388

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 1 addition & 4 deletions third_party/dotnet/devtools/src/generator/Templates/DevToolsSessionDomains.hbs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -27,10 +27,7 @@ namespace {{rootNamespace}}
/// <summary>
/// Gets the adapter for the {{Name}} domain.
/// </summary>
public {{dehumanize Name}}.{{dehumanize Name}}Adapter {{dehumanize Name}}
{
get { return m_{{dehumanize Name}}.Value; }
}
public {{dehumanize Name}}.{{dehumanize Name}}Adapter {{dehumanize Name}} => m_{{dehumanize Name}}.Value;

{{/each}}
/// <summary>
Expand Down
2 changes: 0 additions & 2 deletions third_party/dotnet/devtools/src/generator/Templates/command.hbs
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,7 +1,5 @@
// <auto-generated />

#nullable enable

namespace {{rootNamespace}}.{{domain.Name}}
{
using System.Text.Json.Serialization;
Expand Down
5 changes: 1 addition & 4 deletions third_party/dotnet/devtools/src/generator/Templates/domain.hbs
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,7 +1,5 @@
// <auto-generated />

#nullable enable

namespace {{rootNamespace}}.{{domain.Name}}
{
using System;
Expand Down Expand Up @@ -62,9 +60,8 @@ namespace {{rootNamespace}}.{{domain.Name}}
{
if (e.DomainName == m_domainName)
{
if (m_eventMap.ContainsKey(e.EventName))
if (m_eventMap.TryGetValue(e.EventName, out var eventData))
{
var eventData = m_eventMap[e.EventName];
var eventArgs = e.EventData.Deserialize(eventData.EventArgsType, global::OpenQA.Selenium.DevTools.Json.DevToolsJsonOptions.Default);
eventData.EventInvoker(eventArgs);
}
Expand Down
2 changes: 0 additions & 2 deletions third_party/dotnet/devtools/src/generator/Templates/event.hbs
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,7 +1,5 @@
// <auto-generated />

#nullable enable

namespace {{rootNamespace}}.{{domain.Name}}
{
using System;
Expand Down
2 changes: 0 additions & 2 deletions third_party/dotnet/devtools/src/generator/Templates/type-enum.hbs
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,7 +1,5 @@
// <auto-generated />

#nullable enable

namespace {{rootNamespace}}.{{domain.Name}}
{
using System.Runtime.Serialization;
Expand Down
2 changes: 0 additions & 2 deletions third_party/dotnet/devtools/src/generator/Templates/type-hash.hbs
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,7 +1,5 @@
// <auto-generated />

#nullable enable

namespace {{rootNamespace}}.{{domain.Name}}
{
using System.Collections.Generic;
Expand Down
2 changes: 0 additions & 2 deletions third_party/dotnet/devtools/src/generator/Templates/type-object.hbs
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,7 +1,5 @@
// <auto-generated />

#nullable enable

namespace {{rootNamespace}}.{{domain.Name}}
{
using System.Text.Json.Serialization;
Expand Down
Loading