Skip to content

[java] Enable bidi support for Chrome and Firefox by default #15531

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 1 commit into from
Closed

[java] Enable bidi support for Chrome and Firefox by default #15531

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions java/src/org/openqa/selenium/chromium/ChromiumOptions.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -67,6 +67,7 @@ public class ChromiumOptions<T extends ChromiumOptions<?>>
public ChromiumOptions(String capabilityType, String browserType, String capability) {
this.capabilityName = capability;
setCapability(capabilityType, browserType);
enableBiDi();
}

/**
Expand Down
1 change: 1 addition & 0 deletions java/src/org/openqa/selenium/firefox/FirefoxOptions.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -66,6 +66,7 @@ public FirefoxOptions() {
// will enable it.
// https://fxdx.dev/deprecating-cdp-support-in-firefox-embracing-the-future-with-webdriver-bidi/.
addPreference("remote.active-protocols", 3);
Copy link
Contributor

@whimboo whimboo Mar 31, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@pujagani do you know why this preference is still set to 3 for Java, which basically means that CDP is enabled in Firefox? I thought that with #11736 all the CDP stuff was removed. Maybe it was forgotten?

Copy link
Contributor

@pujagani pujagani Apr 2, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There was pending PR for this. Let me go sort that out. Thank you!

enableBiDi();
Copy link
Contributor

@whimboo whimboo Mar 31, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Would it make sense to give the user a choice to opt-out in case they really don't want to see BiDi enabled?

}

public FirefoxOptions(Capabilities source) {
Expand Down
Loading