Skip to content

[rb] Add support for full page screenshots in Chrome and Edge #16725

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
jspanjers wants to merge 2 commits into from
+10 −4
Closed

[rb] Add support for full page screenshots in Chrome and Edge #16725

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
f02c30f
[rb] add support for Chrome full page screenshot
jspanjers Dec 12, 2025
9b345f9
fixup specs
jspanjers Dec 13, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions rb/lib/selenium/webdriver/chromium/driver.rb
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -40,6 +40,7 @@ class Driver < WebDriver::Driver
DriverExtensions::HasLogs,
DriverExtensions::HasLogEvents,
DriverExtensions::HasPinnedScripts,
DriverExtensions::FullPageScreenshot,
DriverExtensions::PrintsPage].freeze

protected
Expand Down
7 changes: 6 additions & 1 deletion rb/lib/selenium/webdriver/chromium/features.rb
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -28,7 +28,8 @@ module Features
delete_network_conditions: [:delete, 'session/:session_id/chromium/network_conditions'],
set_permission: [:post, 'session/:session_id/permissions'],
get_available_log_types: [:get, 'session/:session_id/se/log/types'],
get_log: [:post, 'session/:session_id/se/log']
get_log: [:post, 'session/:session_id/se/log'],
full_page_screenshot: [:get, 'session/:session_id/screenshot/full']
}.freeze

def launch_app(id)
Expand Down Expand Up @@ -93,6 +94,10 @@ def log(type)
next
end
end

def full_screenshot
execute :full_page_screenshot
end
end # Bridge
end # Chromium
end # WebDriver
Expand Down
6 changes: 3 additions & 3 deletions rb/spec/integration/selenium/webdriver/takes_screenshot_spec.rb
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -95,18 +95,18 @@ def save_screenshot_and_assert(source, path)

it 'takes full page screenshot', except: [{platform: :macosx,
reason: 'showing half resolution of what expected'}],
exclusive: {browser: :firefox} do
exclusive: {browser: %i[firefox chrome edge]} do
viewport_width = driver.execute_script('return window.innerWidth;')
viewport_height = driver.execute_script('return window.innerHeight;')

screenshot = driver.save_screenshot path, full_page: true
width, height = png_size(screenshot)

expect(width).to be >= viewport_width
expect(width).to be <= viewport_width
Copy link
Member

@cgoldberg cgoldberg Dec 15, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

why this change?

expect(height).to be > viewport_height
end

it 'does not take full page screenshot', only: {browser: %i[chrome edge safari safari_preview],
it 'does not take full page screenshot', only: {browser: %i[safari safari_preview],
reason: 'these browsers do not implement this feature'} do
expect {
driver.save_screenshot path, full_page: true
Expand Down
Loading