-
-
Notifications
You must be signed in to change notification settings - Fork 8.6k
[Java] add lint job #16846
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Java] add lint job #16846
Conversation
|
Thank you, @titusfortner for this code suggestion. The support packages contain example code that many users find helpful, but they do not necessarily represent After reviewing the change, unless it is a critical fix or a feature that is needed for Selenium We actively encourage people to add the wrapper and helper code that makes sense for them to their own frameworks. |
PR Compliance Guide 🔍Below is a summary of compliance checks for this PR:
Compliance status legend🟢 - Fully Compliant🟡 - Partial Compliant 🔴 - Not Compliant ⚪ - Requires Further Human Verification 🏷️ - Compliance label |
|||||||||||||||||||||||
PR Code Suggestions ✨Explore these optional code suggestions:
|
|||||||||
User description
We periodically ask people not to commit code with wildcard imports
💥 What does this PR do?
🔧 Implementation Notes
Could have created a separate bazel job, but a lint profile seems like the easiest
💡 Additional Considerations
What other linting things do we want to enforce here?
🔄 Types of changes
PR Type
Enhancement, Tests
Description
Replace wildcard imports with explicit imports across Java codebase
Add lint job to CI pipeline enforcing no wildcard imports
Update Bazel configuration with lint profile for ErrorProne checks
Fix missing dependency in javadoc BUILD configuration
Diagram Walkthrough
File Walkthrough
38 files
Replace wildcard script imports with explicit importsReplace wildcard util and fetch model importsReplace wildcard util and fetch model importsReplace wildcard util and fetch model importsReplace wildcard java.util imports with explicit onesReplace wildcard tomlj imports with explicit importsReplace wildcard java.util imports with explicit onesReplace wildcard static imports with explicit onesReplace wildcard Browser imports with explicit onesReplace wildcard Browser imports with explicit onesReplace wildcard Assertions imports with explicit onesReplace wildcard WaitingConditions imports with explicit onesReplace wildcard Assertions and concurrent importsReplace wildcard static imports with explicit onesReplace wildcard ExpectedConditions and selenium importsReplace wildcard Browser imports with explicit onesReplace wildcard WaitingConditions imports with explicit onesReplace wildcard Browser imports with explicit onesReplace wildcard grid data imports with explicit onesReplace wildcard grid data imports with explicit onesReplace wildcard remote http imports with explicit onesReplace wildcard remote http imports with explicit onesReplace wildcard javax.management imports with explicit onesReplace wildcard selenium imports with explicit onesReplace wildcard grid data imports with explicit onesReplace wildcard concurrent imports with explicit onesReplace wildcard Assertions imports with explicit onesReplace wildcard Assertions imports with explicit onesReplace wildcard java.awt imports with explicit onesReplace wildcard static imports with explicit onesReplace wildcard ExpectedConditions imports with explicit onesReplace wildcard WaitingConditions and ExpectedConditions importsReplace wildcard ExpectedConditions imports with explicit onesReplace wildcard Sets imports with explicit onesReplace wildcard Assertions imports with explicit onesReplace wildcard Assertions imports with explicit onesReplace wildcard Mockito imports with explicit onesReplace wildcard Browser imports with explicit ones2 files
Add lint profile with WildcardImport error checkAdd lint job to CI pipeline workflow1 files
Add missing core-module dependency to javadoc