[rust] Replace fs::rename by file::move_file for Grid artifacts

[bonigarcia]

User description

💥 What does this PR do?

This PR replace the use fs::rename by file::move_file for Grid artifacts, since rename isn't allowed across filesystems.

🔧 Implementation Notes

💡 Additional Considerations

🔄 Types of changes

• Bug fix (backwards compatible)

---

PR Type

Bug fix

---

Description

• Replace fs::rename with file::move_file for Grid artifacts

• Enables cross-filesystem driver file movement in Grid environments

• Adds fs_extra crate dependency for improved file operations

---

Diagram Walkthrough

flowchart LR
  A["fs::rename<br/>limited to same filesystem"] -- "replaced by" --> B["file::move_file<br/>supports cross-filesystem moves"]
  B --> C["Grid artifact handling<br/>now works across filesystems"]

Loading

File Walkthrough

	Relevant files
Bug fix	lib.rs Replace fs::rename with file::move_file for Grid                  rust/src/lib.rs Added imports for fs_extra::file module and CopyOptions Replaced fs::rename call with file::move_file for Grid driver artifacts Uses CopyOptions::new() to configure the move operation +3/-1

---

[qodo-code-review]

PR Compliance Guide 🔍

Below is a summary of compliance checks for this PR:

Security Compliance
🟢	No security concerns identified No security vulnerabilities detected by AI analysis. Human verification advised for critical code.
Ticket Compliance
⚪	🎫 No ticket provided Create ticket/issue
Codebase Duplication Compliance
⚪	Codebase context is not defined Follow the guide to enable codebase context checks.
Custom Compliance
🟢	Generic: Meaningful Naming and Self-Documenting Code Objective: Ensure all identifiers clearly express their purpose and intent, making code self-documenting Status: Passed Learn more about managing compliance generic rules or creating your own custom rules
	Generic: Secure Logging Practices Objective: To ensure logs are useful for debugging and auditing without exposing sensitive information like PII, PHI, or cardholder data. Status: Passed Learn more about managing compliance generic rules or creating your own custom rules
	Generic: Security-First Input Validation and Data Handling Objective: Ensure all data inputs are validated, sanitized, and handled securely to prevent vulnerabilities Status: Passed Learn more about managing compliance generic rules or creating your own custom rules
🔴	Generic: Robust Error Handling and Edge Case Management Objective: Ensure comprehensive error handling that provides meaningful context and graceful degradation Status: Missing error context: The new file::move_file(...) ? propagates errors without adding actionable context (e.g., source/destination paths), reducing debuggability for cross-filesystem move failures. Referred Code file::move_file(driver_zip_file, driver_path_in_cache, &CopyOptions::new())?; } else { Learn more about managing compliance generic rules or creating your own custom rules
⚪	Generic: Comprehensive Audit Trails Objective: To create a detailed and reliable record of critical system actions for security analysis and compliance. Status: No move audit log: The newly added cross-filesystem artifact move operation is not explicitly logged, so it is unclear whether Grid artifact movements are captured in audit trails when required. Referred Code file::move_file(driver_zip_file, driver_path_in_cache, &CopyOptions::new())?; } else { Learn more about managing compliance generic rules or creating your own custom rules
	Generic: Secure Error Handling Objective: To prevent the leakage of sensitive system information through error messages while providing sufficient detail for internal debugging. Status: Error exposure unclear: It is not visible from the diff whether the propagated move_file error (potentially containing filesystem paths) is surfaced to end-users or confined to internal logs/handlers. Referred Code file::move_file(driver_zip_file, driver_path_in_cache, &CopyOptions::new())?; } else { Learn more about managing compliance generic rules or creating your own custom rules

Compliance status legend

🟢 - Fully Compliant
🟡 - Partial Compliant
🔴 - Not Compliant
⚪ - Requires Further Human Verification
🏷️ - Compliance label

[cgoldberg]

LGTM

[qodo-code-review]

PR Code Suggestions ✨

Explore these optional code suggestions:

Category	Suggestion	Impact
Possible issue	Enable overwriting to prevent move failures Set the overwrite option to true in CopyOptions for the file::move_file call to prevent failures if the destination file already exists. rust/src/lib.rs [227] -file::move_file(driver_zip_file, driver_path_in_cache, &CopyOptions::new())?; +let mut options = CopyOptions::new(); +options.overwrite = true; +file::move_file(driver_zip_file, driver_path_in_cache, &options)?; Apply / Chat Suggestion importance[1-10]: 6 __ Why: The suggestion correctly identifies that file::move_file will fail if the destination file exists and proposes enabling overwrite to improve the operation's robustness, which is a valid improvement.	Low
More