[rb] remove stored atoms these get generated by build #16971
Merged
+0
−146
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
User description
Ruby committed pre-built atoms so Ruby users could reference the repo directly in their gemfiles
These were supposed to be overwritten as the source files were updated, but I'm not sure that's happened.
At any rate, we shouldn't do this.
💥 What does this PR do?
Removes the compiled JavaScript atom files from
rb/lib/selenium/webdriver/atoms/.findElements.jsgetAttribute.jsisDisplayed.jsmutationListener.js💡 Additional Considerations
Tests are run against generated binaries, so this is only an issue if someone is pointing at Selenium from their repos
and the atoms are out of date. All unlikely.
🔄 Types of changes
PR Type
Enhancement
Description
Remove pre-built JavaScript atom files from Ruby bindings
These files are generated during build process, not manually maintained
Eliminates outdated atom files that could cause issues for direct repo users
Simplifies repository by removing generated artifacts
Diagram Walkthrough
File Walkthrough
findElements.js
Delete findElements atom filerb/lib/selenium/webdriver/atoms/findElements.js
getAttribute.js
Delete getAttribute atom filerb/lib/selenium/webdriver/atoms/getAttribute.js
isDisplayed.js
Delete isDisplayed atom filerb/lib/selenium/webdriver/atoms/isDisplayed.js
mutationListener.js
Delete mutationListener atom filerb/lib/selenium/webdriver/atoms/mutationListener.js
lines)