Skip to content

[build] Fix Lint Format CI#17202

Merged
VietND96 merged 1 commit intotrunkfrom
fix-lint
Mar 11, 2026
Merged

[build] Fix Lint Format CI#17202
VietND96 merged 1 commit intotrunkfrom
fix-lint

Conversation

@VietND96
Copy link
Member

@VietND96 VietND96 commented Mar 11, 2026

🔗 Related Issues

💥 What does this PR do?

Fix Lint Format CI broken from #17193

🔧 Implementation Notes

💡 Additional Considerations

🔄 Types of changes

  • Cleanup (formatting, renaming)
  • Bug fix (backwards compatible)
  • New feature (non-breaking change which adds functionality and tests!)
  • Breaking change (fix or feature that would cause existing functionality to change)

Signed-off-by: Viet Nguyen Duc <nguyenducviet4496@gmail.com>
@selenium-ci selenium-ci added the C-py Python Bindings label Mar 11, 2026
@qodo-code-review
Copy link
Contributor

Review Summary by Qodo

Reformat test code to fix linting violations

✨ Enhancement

Grey Divider

Walkthroughs

Description
• Reformatted multi-line function calls to single-line format
• Improved code readability by collapsing lambda expressions
• Applied consistent line length formatting across test files
• Fixed linting violations in BiDi-related test modules

Grey Divider

File Changes

1. py/test/selenium/webdriver/common/bidi_input_tests.py Formatting +20/-70

Reformat multi-line calls to single-line format

• Collapsed multi-line WebDriverWait calls into single lines
• Reformatted multi-line function arguments to single-line format
• Simplified WheelScrollAction and tempfile.NamedTemporaryFile calls
• Consolidated driver.input.perform_actions and driver.input.set_files calls

py/test/selenium/webdriver/common/bidi_input_tests.py


2. py/test/selenium/webdriver/common/bidi_integration_tests.py Formatting +3/-9

Collapse multi-line WebDriverWait and API calls

• Collapsed multi-line WebDriverWait lambda expressions to single lines
• Reformatted driver.add_cookie call to single line
• Simplified driver.browsing_context.navigate call

py/test/selenium/webdriver/common/bidi_integration_tests.py


3. py/test/selenium/webdriver/common/bidi_log_tests.py Formatting +1/-3

Reformat WebDriverWait call to single line

• Collapsed multi-line WebDriverWait lambda expression to single line

py/test/selenium/webdriver/common/bidi_log_tests.py


View more (3)
4. py/test/selenium/webdriver/common/bidi_script_tests.py Formatting +15/-45

Reformat script API calls and WebDriverWait expressions

• Collapsed multiple multi-line WebDriverWait calls to single lines
• Reformatted driver.script._add_preload_script calls
• Simplified driver.script._evaluate and driver.script._disown calls
• Consolidated driver.script._call_function and other script API calls

py/test/selenium/webdriver/common/bidi_script_tests.py


5. py/test/selenium/webdriver/common/bidi_storage_tests.py Formatting +11/-33

Reformat storage API and cookie-related calls

• Collapsed multi-line CookieFilter and PartialCookie instantiations
• Reformatted driver.storage.get_cookies and driver.storage.set_cookie calls
• Simplified driver.browsing_context.create call
• Consolidated cookie-related API calls to single lines

py/test/selenium/webdriver/common/bidi_storage_tests.py


6. py/test/selenium/webdriver/common/bidi_webextension_tests.py Formatting +10/-37

Reformat webextension test calls and assertions

• Collapsed multi-line function calls to single lines
• Reformatted WebDriverWait lambda expressions
• Simplified assertion statements with multi-line conditions
• Consolidated extension installation and uninstallation calls

py/test/selenium/webdriver/common/bidi_webextension_tests.py


Grey Divider

Qodo Logo

@qodo-code-review
Copy link
Contributor

qodo-code-review bot commented Mar 11, 2026

Code Review by Qodo

🐞 Bugs (0) 📘 Rule violations (0) 📎 Requirement gaps (0)

Grey Divider

Great, no issues found!

Qodo reviewed your code and found no material issues that require review

Grey Divider

ⓘ The new review experience is currently in Beta. Learn more

Grey Divider

Qodo Logo

@VietND96 VietND96 changed the title [build] Fix Lint CI [build] Fix Lint Format CI Mar 11, 2026
@VietND96 VietND96 merged commit c9cfcf8 into trunk Mar 11, 2026
38 of 40 checks passed
@VietND96 VietND96 deleted the fix-lint branch March 11, 2026 05:22
AutomatedTester pushed a commit that referenced this pull request Mar 11, 2026
Signed-off-by: Viet Nguyen Duc <nguyenducviet4496@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

C-py Python Bindings

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants