[dotnet] [test] Rename namespace for common test project#17276
Merged
nvborisenko merged 6 commits intoSeleniumHQ:trunkfrom Mar 30, 2026
Merged
[dotnet] [test] Rename namespace for common test project#17276nvborisenko merged 6 commits intoSeleniumHQ:trunkfrom
nvborisenko merged 6 commits intoSeleniumHQ:trunkfrom
Conversation
selenium-ci
added
C-dotnet
Member
|
Thank you, @nvborisenko for this code suggestion. The support packages contain example code that many users find helpful, but they do not necessarily represent After reviewing the change, unless it is a critical fix or a feature that is needed for Selenium We actively encourage people to add the wrapper and helper code that makes sense for them to their own frameworks. |
Contributor
Review Summary by QodoRefactor .NET test suite with unified namespace structure and infrastructure reorganization
WalkthroughsDescriptionComprehensive refactoring of the .NET test suite to improve code organization and maintainability: * **Namespace reorganization**: Moved all test classes from scattered namespaces (e.g., OpenQA.Selenium, OpenQA.Selenium.DevTools, OpenQA.Selenium.BiDi.*) into a unified structure under OpenQA.Selenium.Common.Tests and its sub-namespaces * **Infrastructure consolidation**: Reorganized test infrastructure and utilities into OpenQA.Selenium.Common.Tests.Infrastructure with sub-folders for DriverConfigs and Environment * **Global usings**: Added centralized GlobalUsings.cs file to reduce import duplication across test files * **Import standardization**: Updated all references from OpenQA.Selenium.Environment to OpenQA.Selenium.Common.Tests.Infrastructure.Environment throughout the test suite * **Browser enum simplification**: Simplified IgnoreBrowser attributes by removing Selenium. prefix and using Infrastructure.Browser references * **Type reference cleanup**: Removed unnecessary namespace prefixes in type references (e.g., BrowsingContext.ContextType.Window → ContextType.Window) * **Unused imports removal**: Cleaned up unused using statements across all test files * **Project configuration**: Updated Selenium.WebDriver.Common.Tests.csproj root namespace and appconfig.json driver configuration references File Changes1. dotnet/test/common/DevTools/DevToolsNetworkTests.cs
|
Contributor
Code Review by Qodo
1. RootNamespace set to Common.Tests
|
![qodo-code-review[bot]](https://avatars.githubusercontent.com/in/484649?s=60&v=4){kind=small}
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Trying to clean common test project:
Infrastructurefolder🔗 Related Issues
Contributes to #15536
💥 What does this PR do?
This pull request restructures the .NET WebDriver test suite by consolidating the shared test code from the
commontest project into a newwebdrivertest project. All references, dependencies, and visibility settings have been updated accordingly across the build system, solution, and test projects. Additionally, some namespace imports have been updated to reflect the new organization.Key changes:
Test Project Consolidation and References
dotnet/test/commontest project and introduceddotnet/test/webdriveras the new location for shared test code. All test projects and build files now referencewebdriverinstead ofcommon. [1] [2] [3] [4] [5] [6] [7]Build and Visibility Updates
commonwithwebdriverfor test data, dependencies, and visibility settings, ensuring the new shared test project is used throughout. [1] [2] [3] [4] [5] [6]InternalsVisibleTo and Assembly Metadata
InternalsVisibleToattributes and related metadata fromWebDriver.Common.TeststoWebDriver.Testsin both project files and Bazel build definitions. [1] [2] [3] [4]Namespace and Import Adjustments
usingstatements in test files to import from the newOpenQA.Selenium.TestsandOpenQA.Selenium.Tests.Infrastructure.Environmentnamespaces, reflecting the new project structure. [1] [2] [3] [4] [5]These changes improve the maintainability and clarity of the .NET WebDriver test suite by centralizing shared test infrastructure and updating references throughout the codebase.
🔄 Types of changes