fix(pre-release): simplify dependency update command and ensure cargo…#17320
Merged
fix(pre-release): simplify dependency update command and ensure cargo…#17320
Conversation
… repin after version update
Contributor
Review Summary by QodoFix pre-release by repinning cargo immediately after version update
WalkthroughsDescription• Automatically repin cargo after version update to prevent lockfile staleness • Removes redundant rust:update call from workflow, now handled in rake task • Prevents Bazel file-hash conflicts during mid-evaluation lockfile updates File Changes1. rake_tasks/rust.rake
|
Contributor
Code Review by Qodo🐞 Bugs (0) 📘 Rule violations (0) 📎 Requirement gaps (0)
Great, no issues found!Qodo reviewed your code and found no material issues that require reviewⓘ The new review experience is currently in Beta. Learn more |
Contributor
There was a problem hiding this comment.
Pull request overview
This PR adjusts the release-prep automation so Rust crate repinning happens immediately after bumping the Rust version, and simplifies the pre-release dependency update command accordingly.
Changes:
- Invoke
rust:updatefrom withinrust:versionto repin Cargo immediately after a version bump. - Simplify the pre-release workflow dependency update step to run a single
./go <language>:updatecommand.
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 1 comment.
| File | Description |
|---|---|
rake_tasks/rust.rake |
Runs rust:update right after updating Rust version to keep Cargo.Bazel.lock in sync during release prep. |
.github/workflows/pre-release.yml |
Removes the special-case && ./go rust:update append and relies on repinning during version bump. |
AutomatedTester
pushed a commit
that referenced
this pull request
Apr 9, 2026
#17320) * fix(pre-release): simplify dependency update command and ensure cargo repin after version update * fix(rust): reenable task invocation for rust:update to prevent no-op issues
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
fix(pre-release): simplify dependency update command and ensure cargo repin after version update