Skip to content

update qodo configuration for v2#17424

Merged
titusfortner merged 2 commits intotrunkfrom
qodo2
May 8, 2026
Merged

update qodo configuration for v2#17424
titusfortner merged 2 commits intotrunkfrom
qodo2

Conversation

@titusfortner
Copy link
Copy Markdown
Member

💥 What does this PR do?

We were using outdated configurations

🔧 Implementation Notes

Removed the auto-tagging (which I'm not sure was working anyway); we're doing that deterministically elsewhere good enough
Allowing new commits to automatically rerun the review is the big one

Copilot AI review requested due to automatic review settings May 8, 2026 09:08
@qodo-code-review
Copy link
Copy Markdown
Contributor

Review Summary by Qodo

Update Qodo configuration to v2 with GitHub app integration

📦 Other

Grey Divider

Walkthroughs

Description
• Simplified Qodo configuration from v1 to v2
• Removed custom label definitions and auto-tagging
• Added GitHub app commands for PR review automation
• Enabled automatic review on push events

Grey Divider

File Changes

1. .pr_agent.toml ⚙️ Configuration changes +11/-85

Migrate Qodo configuration from v1 to v2

• Replaced outdated v1 configuration with v2 GitHub app setup
• Removed 85 lines of custom label definitions and PR description settings
• Added GitHub app commands for agentic describe and review
• Enabled push trigger to automatically run reviews on new commits

.pr_agent.toml


Grey Divider

Qodo Logo

@qodo-code-review
Copy link
Copy Markdown
Contributor

qodo-code-review Bot commented May 8, 2026

Code Review by Qodo

🐞 Bugs (1) 📘 Rule violations (0)

Grey Divider


Remediation recommended

1. Push-triggered review not scoped 🐞 Bug ☼ Reliability
Description
handle_push_trigger = true will run /agentic_review on push events, which can unintentionally
trigger reviews on non-PR automated pushes and create redundant bot runs/comments. This repo
contains workflows that perform git push (including to gh-pages and force-push scenarios),
increasing the chance of unintended triggers.
Code

.pr_agent.toml[R8-11]

+handle_push_trigger = true
+push_commands = [
+    "/agentic_review",
+]
Evidence
The new Qodo config explicitly enables push-trigger handling and sets /agentic_review as the
command to run on pushes. Separately, the repo includes GitHub Actions workflows that push commits
to branches (e.g., documentation publishing to gh-pages, and a reusable workflow that can
push/force-push changes), so enabling push-trigger reviews can cause Qodo to run outside the
intended PR-review flow.

.pr_agent.toml[8-11]
.github/workflows/update-documentation.yml[93-110]
.github/workflows/commit-changes.yml[74-86]

Agent prompt
The issue below was found during a code review. Follow the provided context and guidance below and implement a solution

### Issue description
`.pr_agent.toml` enables push-triggered reviews (`handle_push_trigger = true`) and runs `/agentic_review` on pushes. In a repo with automation that performs `git push`, this can cause unintended review runs on non-PR branches (e.g., `gh-pages`) or on bot-driven pushes.

### Issue Context
This is primarily an operational reliability/noise concern: unexpected bot runs, duplicate reviews, and extra load.

### Fix Focus Areas
- .pr_agent.toml[8-11]
- .github/workflows/update-documentation.yml[93-110]
- .github/workflows/commit-changes.yml[74-86]

### Suggested fix
- If Qodo v2 supports it, add branch allow/deny scoping for push triggers (e.g., only PR branches; ignore `gh-pages` and other automation branches).
- Otherwise, set `handle_push_trigger = false` and rely on `pr_commands` (or manual `/agentic_review`) to avoid push-driven reruns triggered by automation.

ⓘ Copy this prompt and use it to remediate the issue with your preferred AI generation tools


Grey Divider

Qodo Logo

Copy link
Copy Markdown
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Updates the repository’s Qodo Review configuration to the v2 schema, focusing on deterministic command handling and enabling review reruns on new commits.

Changes:

  • Replaced the legacy qodo-merge-pro configuration (PR description/labeler/custom labels) with a minimal Qodo Review v2 [github_app] configuration.
  • Enabled push-triggered reruns by setting handle_push_trigger = true and configuring push_commands.

Note: after updating repo config files, run ./go format to avoid CI formatter failures.

@titusfortner titusfortner merged commit e46a050 into trunk May 8, 2026
26 checks passed
@titusfortner titusfortner deleted the qodo2 branch May 8, 2026 11:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants