Skip to content

[dotnet] [build] Format solution instead of projects #17457

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
nvborisenko wants to merge 13 commits into from
+21 −22
Closed

[dotnet] [build] Format solution instead of projects #17457

Changes from all commits
Commits
Show all changes
13 commits
Select commit Hold shift + click to select a range
6b3669a
[dotnet] [build] Format solution instead of projects
nvborisenko May 14, 2026
62eaf58
Relative slnx path
nvborisenko May 14, 2026
a86574c
Temp debug
nvborisenko May 14, 2026
b830024
Revert and diagnose
nvborisenko May 14, 2026
e54dda0
Temp fail
nvborisenko May 14, 2026
5ca5264
Direct out
nvborisenko May 14, 2026
0606f5f
Execute at all?
nvborisenko May 14, 2026
71210e8
Fallback to manifest
nvborisenko May 14, 2026
585fbf0
Add debug
nvborisenko May 14, 2026
208c1f0
RUNFILES_DIR
nvborisenko May 14, 2026
ea829a7
Env vars
nvborisenko May 14, 2026
c471cca
bat in the name
nvborisenko May 14, 2026
f541dc9
Set DOTNET_ROOT
nvborisenko May 14, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
43 changes: 21 additions & 22 deletions dotnet/private/dotnet_format.bzl
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -52,11 +52,8 @@ DOTNET_DIR="$WORKSPACE_ROOT/dotnet"

cd "$DOTNET_DIR"

echo "Running dotnet format $@ on all projects..."
find "$DOTNET_DIR/src" "$DOTNET_DIR/test" -name "*.csproj" 2>/dev/null | while read -r proj; do
echo " Formatting $proj..."
"$DOTNET" format "$@" "$proj" || exit 1
done || exit 1
echo "Running dotnet format $@ on Selenium.slnx..."
"$DOTNET" format "$@" Selenium.slnx || exit 1

echo "Done."
""".format(
Expand All @@ -76,30 +73,32 @@ def _create_windows_script(ctx, dotnet):
dotnet_runfiles_path = _to_runfiles_path(dotnet.short_path).replace("/", "\\")

script_content = """@echo off
setlocal
setlocal enabledelayedexpansion

set RUNFILES_DIR=%~dp0%~n0.runfiles
set DOTNET=%RUNFILES_DIR%\\{dotnet_path}
rem Resolve runfiles (Windows: <name>.bat.runfiles, Unix: <name>.runfiles)
set "RF_DIR=%~dp0%~nx0.runfiles"
if not exist "!RF_DIR!" set "RF_DIR=%~dp0%~n0.runfiles"

if defined BUILD_WORKSPACE_DIRECTORY (
set WORKSPACE_ROOT=%BUILD_WORKSPACE_DIRECTORY%
) else (
set WORKSPACE_ROOT=%RUNFILES_DIR%\\_main
set "DOTNET=!RF_DIR!\\{dotnet_path}"
if not exist "!DOTNET!" (
echo ERROR: dotnet not found at !DOTNET! 1>&2
exit /b 1
)
set DOTNET_DIR=%WORKSPACE_ROOT%\\dotnet

cd /d "%DOTNET_DIR%"
rem Set DOTNET_ROOT so MSBuild SDK resolver can find the SDK
for %%I in ("!DOTNET!") do set "DOTNET_ROOT=%%~dpI"
set "PATH=!DOTNET_ROOT!;!PATH!"

echo Running dotnet format %* on all projects...
for /r "%DOTNET_DIR%\\src" %%p in (*.csproj) do (
echo Formatting %%p...
"%DOTNET%" format %* "%%p" || exit /b 1
)
for /r "%DOTNET_DIR%\\test" %%p in (*.csproj) do (
echo Formatting %%p...
"%DOTNET%" format %* "%%p" || exit /b 1
set "DOTNET_DIR=%BUILD_WORKSPACE_DIRECTORY%\\dotnet"
cd /d "!DOTNET_DIR!" || (
echo ERROR: Could not cd to !DOTNET_DIR! 1>&2
exit /b 1
)

echo Running dotnet format %* on Selenium.slnx...
"!DOTNET!" format %* Selenium.slnx
if errorlevel 1 exit /b 1

echo Done.
""".format(
dotnet_path = dotnet_runfiles_path,
Expand Down
Loading