Skip to content
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 0 additions & 1 deletion package.json
Original file line number Diff line number Diff line change
@@ -1,6 +1,5 @@
{
"name": "selenium",
"packageManager": "pnpm@9.15.4",
"workspaces": [
"javascript/grid-ui",
"javascript/selenium-webdriver"
Expand Down
4 changes: 2 additions & 2 deletions rake_tasks/bazel.rb
Original file line number Diff line number Diff line change
Expand Up @@ -25,8 +25,8 @@

puts "Executing: #{cmd.join(' ')}"
if windows?
cmd += ['2>&1']
cmd_line = cmd.join(' ')
quoted = cmd.map { |a| a.match?(/[\s"]/) ? %("#{a.gsub('"', '\\"')}") : a }

Check failure

Code scanning / CodeQL

Incomplete string escaping or encoding High

This does not escape backslash characters in the input.
Comment thread
titusfortner marked this conversation as resolved.
Dismissed
cmd_line = "#{quoted.join(' ')} 2>&1"
Comment thread
titusfortner marked this conversation as resolved.
cmd_out = `#{cmd_line}`.encode('UTF-8', 'binary', invalid: :replace, undef: :replace, replace: '')
puts cmd_out if verbose
cmd_exit_code = $CHILD_STATUS
Expand Down
7 changes: 3 additions & 4 deletions rake_tasks/node.rake
Original file line number Diff line number Diff line change
Expand Up @@ -111,12 +111,11 @@ task :docs_generate do
Bazel.execute('run', [], '//javascript/selenium-webdriver:docs')
end

desc 'Install Node package locally via npm link'
desc 'Install Node package locally via pnpm link'
task :install do
Bazel.execute('build', [], '//javascript/selenium-webdriver')
Dir.chdir('bazel-bin/javascript/selenium-webdriver/selenium-webdriver') do
sh 'npm', 'link'
end
pkg_dir = File.expand_path('bazel-bin/javascript/selenium-webdriver/selenium-webdriver')
Bazel.execute('run', ['--', '--dir', pkg_dir, 'link', '--global'], '@pnpm//:pnpm')
Comment thread
titusfortner marked this conversation as resolved.
end

desc 'Update JavaScript changelog'
Expand Down
Loading