Skip to content

[dotnet] [test] Resolve obsolete warning about NUnit TestDelegate#17520

Merged
nvborisenko merged 1 commit into
SeleniumHQ:trunkfrom
nvborisenko:dotnet-test-warn
May 19, 2026
Merged

[dotnet] [test] Resolve obsolete warning about NUnit TestDelegate#17520
nvborisenko merged 1 commit into
SeleniumHQ:trunkfrom
nvborisenko:dotnet-test-warn

Conversation

@nvborisenko
Copy link
Copy Markdown
Member

Resolves build warnings.

🔧 Implementation Notes

Use Action instead.

🤖 AI assistance

  • No substantial AI assistance used
  • AI assisted (complete below)
    • Tool(s):
    • What was generated:
    • I reviewed all AI output and can explain the change

💡 Additional Considerations

🔄 Types of changes

  • Cleanup (formatting, renaming)

@qodo-code-review
Copy link
Copy Markdown
Contributor

Review Summary by Qodo

Replace obsolete NUnit TestDelegate with Action

🐞 Bug fix

Grey Divider

Walkthroughs

Description
• Replace obsolete NUnit TestDelegate with Action delegate
• Resolves build warnings in page load timeout test
Diagram
flowchart LR
  A["TestDelegate parameter"] -- "replaced with" --> B["Action parameter"]
  B -- "in method" --> C["AssertPageLoadTimeoutIsEnforced"]
Loading

Grey Divider

File Changes

1. dotnet/test/webdriver/PageLoadingTests.cs 🐞 Bug fix +2/-2

Replace TestDelegate with Action delegate type

• Changed method parameter type from TestDelegate to Action in AssertPageLoadTimeoutIsEnforced
 method
• Updated method call to use action parameter instead of delegateToTest
• Resolves obsolete API warning from NUnit

dotnet/test/webdriver/PageLoadingTests.cs


Grey Divider

Qodo Logo

@selenium-ci selenium-ci added the C-dotnet .NET Bindings label May 19, 2026
@qodo-code-review
Copy link
Copy Markdown
Contributor

qodo-code-review Bot commented May 19, 2026

Code Review by Qodo

🐞 Bugs (0) 📘 Rule violations (0) 📎 Requirement gaps (0)

Grey Divider

Great, no issues found!

Qodo reviewed your code and found no material issues that require review

Grey Divider

Qodo Logo

@nvborisenko nvborisenko merged commit c75a12b into SeleniumHQ:trunk May 19, 2026
33 of 36 checks passed
@nvborisenko nvborisenko deleted the dotnet-test-warn branch May 19, 2026 14:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

C-dotnet .NET Bindings

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants