Skip to content

[build] dependency changes should run CI tests for given binding #17534

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
titusfortner merged 2 commits into from
May 20, 2026
+18 −6
Merged

[build] dependency changes should run CI tests for given binding #17534

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
6934c43
[build] dependency changes should run CI tests for given binding
titusfortner May 20, 2026
afd6d2d
[build] filter overridden targets from index results instead of files
titusfortner May 20, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
24 changes: 18 additions & 6 deletions rake_tasks/bazel.rake
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3,9 +3,18 @@
require 'json'
require 'set'

# Dirs that affect all bindings - changes here trigger "run all tests"
HIGH_IMPACT_DIRS = %w[common rust/src javascript/atoms javascript/webdriver/atoms].freeze
HIGH_IMPACT_PATTERN = %r{\A(?:#{HIGH_IMPACT_DIRS.map { |d| Regexp.escape(d) }.join('|')})(?:/|$)}
# Paths that affect every binding - changes here trigger "run all tests"
HIGH_IMPACT_PATHS = %w[common rust/src javascript/atoms javascript/webdriver/atoms MODULE.bazel].freeze
HIGH_IMPACT_PATTERN = %r{\A(?:#{HIGH_IMPACT_PATHS.map { |p| Regexp.escape(p) }.join('|')})(?:/|$)}

# Binding overrides for files the index can't reach (workspace dep files, root configs)
TARGET_OVERRIDES = {
'dotnet/paket.lock' => 'dotnet',
'java/maven_install.json' => 'java',
'py/requirements_lock.txt' => 'py',
'rb/Gemfile.lock' => 'rb',
'javascript/selenium-webdriver/package.json' => 'javascript'
}.freeze

# ./go bazel:affected_targets --> HEAD^..HEAD with default index
# ./go bazel:affected_targets abc123..def456 --> explicit range
Expand Down Expand Up @@ -34,7 +43,10 @@ task :affected_targets do |_task, args|
targets = if changed_files.any? { |f| f.match?(HIGH_IMPACT_PATTERN) }
BINDING_TARGETS.values
elsif File.exist?(index_file)
affected_targets_with_index(changed_files, index_file)
override_targets = changed_files.filter_map { |f| BINDING_TARGETS[TARGET_OVERRIDES[f]] }
covered_pattern = Regexp.union(override_targets.map { |t| %r{\A#{Regexp.escape(t.delete_suffix('/...'))}[:/]} })
index_targets = affected_targets_with_index(changed_files, index_file).grep_v(covered_pattern)
(override_targets + index_targets).uniq
else
puts 'No index found, using directory-based fallback'
affected_targets_by_directory(changed_files)
Expand Down Expand Up @@ -98,8 +110,8 @@ def query_test_deps(test)
deps = out.lines.map(&:strip).select { |l| l.start_with?('//') }
end
deps.reject do |d|
# Skip high-impact dirs and root package targets (generated files, LICENSE, etc)
HIGH_IMPACT_DIRS.any? { |dir| d.start_with?("//#{dir}") } || d.start_with?('//:')
# Skip high-impact paths and root package targets (generated files, LICENSE, etc)
HIGH_IMPACT_PATHS.any? { |path| d.start_with?("//#{path}") } || d.start_with?('//:')
end
rescue StandardError => e
puts " Warning: Failed to query deps for #{test}: #{e.message}"
Expand Down
Loading