[rb] update bazel test tags#17558
Merged
Merged
Conversation
selenium-ci
added
C-rb
Contributor
Review Summary by QodoReorganize Bazel test tags with bidi opt-in and test categorization
WalkthroughsDescription• Add bidi opt-in flag to chrome-beta, edge, and firefox-beta browsers • Implement bidi_only parameter to generate bidi-only test targets • Remove redundant skip-rbe tags from ie, safari, and safari-preview • Reorganize test categorization with OS-sensitive, bidi-dual, and bidi-only test groups • Update unit test tag from no-sandbox to unit for better filtering Diagramflowchart LR
A["Browser Config"] -->|"Add bidi flag"| B["chrome-beta, edge, firefox-beta"]
C["Test Generation"] -->|"bidi_only param"| D["Conditional target creation"]
E["Tag Cleanup"] -->|"Remove skip-rbe"| F["Use target_compatible_with"]
G["Test Organization"] -->|"Categorize tests"| H["OS-sensitive, Bidi-dual, Bidi-only"]
File Changes1. rb/spec/tests.bzl
|
Contributor
Code Review by Qodo
1. Unquoted rm -rf $path
|
Contributor
There was a problem hiding this comment.
Pull request overview
This PR refactors Ruby Bazel test tagging and target generation to better separate classic vs BiDi execution, reduce no-op targets, and introduce new tags for OS-sensitive and unit tests.
Changes:
- Adds BiDi opt-in metadata per browser and a
bidi_onlyoption to generate only BiDi targets where applicable. - Introduces
os-sensitivetagging for selected integration specs and marks certain service specs as OS-sensitive. - Replaces Ruby unit test tagging from
no-sandboxtounit, and removes redundantskip-rbetags wheretarget_compatible_withalready prevents execution.
Reviewed changes
Copilot reviewed 6 out of 6 changed files in this pull request and generated 1 comment.
Show a summary per file
| File | Description |
|---|---|
| rb/spec/tests.bzl | Adds bidi_only behavior and browser BiDi opt-in; adjusts unit test tags |
| rb/spec/integration/selenium/webdriver/firefox/BUILD.bazel | Adds os-sensitive tag to Firefox service integration test |
| rb/spec/integration/selenium/webdriver/edge/BUILD.bazel | Adds os-sensitive tag to Edge service integration test |
| rb/spec/integration/selenium/webdriver/chrome/BUILD.bazel | Adds os-sensitive tag to Chrome service integration test |
| rb/spec/integration/selenium/webdriver/BUILD.bazel | Splits integration specs into OS-sensitive, BiDi-dual, BiDi-only, and devtools groups |
| rb/spec/integration/selenium/webdriver/bidi/BUILD.bazel | Switches BiDi integration specs to bidi_only targets |
titusfortner
force-pushed
the
bazel_tags_rb
branch
from
e29341c to
2e670fb
Compare
Contributor
|
Persistent review updated to latest commit 2e670fb |
![qodo-code-review[bot]](https://avatars.githubusercontent.com/in/484649?s=60&v=4){kind=small}
titusfortner
force-pushed
the
bazel_tags_rb
branch
from
2e670fb to
30e20fb
Compare
Contributor
|
Persistent review updated to latest commit 30e20fb |
titusfortner
force-pushed
the
bazel_tags_rb
branch
from
30e20fb to
6a4c0ba
Compare
Contributor
|
Persistent review updated to latest commit 6a4c0ba |
titusfortner
force-pushed
the
bazel_tags_rb
branch
from
6a4c0ba to
0d5a406
Compare
Contributor
|
Persistent review updated to latest commit 0d5a406 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When I last reorganized the bazel tags I had a few different ideas conflated.
Ruby toggles bidi-enabled in the settings. We want all -bidi targets to enable Bidi and everything else not enabled, and not to have extra targets that are always skipped.
💥 What does this PR do?
bidi_only = True- enables bidi just for chrome-beta, firefox-beta and edge to minimize targets; does not create non-bidi targets that can't be run without a websocketremoves 84 no-op targets removed
🔧 Implementation Notes
🤖 AI assistance