[py] mark Safari tests broken by SafariDriver 26.5 as xfail#17560
Conversation
Review Summary by QodoMark Safari tests broken by SafariDriver 26.5 regression as xfail
WalkthroughsDescription• Mark 72 Safari tests as xfail due to SafariDriver 26.5 regression • Regression affects alert handling, click delivery, and interactions • Tests span alerts, clicking, forms, frames, typing, waits, windows • CI will report XFAIL instead of blocking merges until Apple fixes Diagramflowchart LR
A["SafariDriver 26.5 Regression"] -->|affects| B["Alert Handling"]
A -->|affects| C["Click Delivery"]
A -->|affects| D["Form Interactions"]
B -->|mark xfail| E["72 Tests"]
C -->|mark xfail| E
D -->|mark xfail| E
E -->|result| F["XFAIL Status in CI"]
File Changes1. py/test/selenium/webdriver/common/alerts_tests.py
|
Code Review by Qodo
1. Mass xfail_safari decorator churn
|
|
Thank you, @titusfortner for this code suggestion. The support packages contain example code that many users find helpful, but they do not necessarily represent After reviewing the change, unless it is a critical fix or a feature that is needed for Selenium We actively encourage people to add the wrapper and helper code that makes sense for them to their own frameworks. |
|
Persistent review updated to latest commit 9e63a61 |
9e63a61 to
f01aec4
Compare
|
Persistent review updated to latest commit f01aec4 |
f01aec4 to
e1dc860
Compare
|
Persistent review updated to latest commit e1dc860 |
|
Persistent review updated to latest commit 581ab0a |
|
Persistent review updated to latest commit a6c7697 |
The macos-15-arm64 runner image bumped Safari/SafariDriver from 26.3 to 26.5, which regressed alert handling (no such alert 404s) and synthetic click delivery across alerts, click, form, frame switching, interactions, typing, waits, and window switching tests.
💥 What does this PR do?
Mark the 72 affected tests xfail_safari so CI surfaces them as XFAIL rather than blocking merges; they will report XPASS once Apple ships a fix.
🔧 Implementation Notes
We could mark these as xfail strict to see when they start passing again
🤖 AI assistance