[rust] Reuse constant for --version#17579
Merged
Merged
Conversation
Contributor
Review Summary by QodoReuse DASH_DASH_VERSION constant for driver version checks
WalkthroughsDescription• Reuse DASH_DASH_VERSION constant instead of hardcoded strings • Replace hardcoded "--version" with constant in driver version command • Update test utilities to use the shared constant • Improve code maintainability and consistency Diagramflowchart LR
A["Hardcoded --version strings"] -->|Replace with constant| B["DASH_DASH_VERSION constant"]
B -->|Used in| C["lib.rs find_driver_in_path"]
B -->|Used in| D["tests/common.rs exec_driver"]
File Changes1. rust/src/lib.rs
|
Contributor
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
🔗 Related Issues
💥 What does this PR do?
🔧 Implementation Notes
🤖 AI assistance
💡 Additional Considerations
🔄 Types of changes