Skip to content

[rust] Reuse constant for --version#17579

Merged
bonigarcia merged 1 commit into
trunkfrom
sm_dash_dash
May 27, 2026
Merged

[rust] Reuse constant for --version#17579
bonigarcia merged 1 commit into
trunkfrom
sm_dash_dash

Conversation

@bonigarcia
Copy link
Copy Markdown
Member

🔗 Related Issues

💥 What does this PR do?

🔧 Implementation Notes

🤖 AI assistance

  • No substantial AI assistance used
  • AI assisted (complete below)
    • Tool(s):
    • What was generated:
    • I reviewed all AI output and can explain the change

💡 Additional Considerations

🔄 Types of changes

  • Cleanup (formatting, renaming)
  • Bug fix (backwards compatible)
  • New feature (non-breaking change which adds functionality and tests!)
  • Breaking change (fix or feature that would cause existing functionality to change)

@bonigarcia bonigarcia merged commit 73019cd into trunk May 27, 2026
12 of 15 checks passed
@bonigarcia bonigarcia deleted the sm_dash_dash branch May 27, 2026 12:00
@selenium-ci selenium-ci added C-rust Rust code is mostly Selenium Manager B-manager Selenium Manager labels May 27, 2026
@qodo-code-review
Copy link
Copy Markdown
Contributor

Review Summary by Qodo

Reuse DASH_DASH_VERSION constant for driver version checks

✨ Enhancement

Grey Divider

Walkthroughs

Description
• Reuse DASH_DASH_VERSION constant instead of hardcoded strings
• Replace hardcoded "--version" with constant in driver version command
• Update test utilities to use the shared constant
• Improve code maintainability and consistency
Diagram
flowchart LR
  A["Hardcoded --version strings"] -->|Replace with constant| B["DASH_DASH_VERSION constant"]
  B -->|Used in| C["lib.rs find_driver_in_path"]
  B -->|Used in| D["tests/common.rs exec_driver"]

Loading

Grey Divider

File Changes

1. rust/src/lib.rs ✨ Enhancement +4/-2

Use constant for driver version command

• Replace hardcoded "--version" string with DASH_DASH_VERSION constant
• Reformat Command::new() call for better readability
• Maintain same functionality while improving code reusability

rust/src/lib.rs


2. rust/tests/common.rs ✨ Enhancement +3/-1

Import and use version constant in tests

• Import DASH_DASH_VERSION constant from selenium_manager
• Replace hardcoded "--version" string with constant in exec_driver function
• Align test code with main library constant usage

rust/tests/common.rs


Grey Divider

Qodo Logo

@qodo-code-review
Copy link
Copy Markdown
Contributor

qodo-code-review Bot commented May 27, 2026

Code Review by Qodo

🐞 Bugs (0) 📘 Rule violations (0) 📎 Requirement gaps (0)

Grey Divider

Great, no issues found!

Qodo reviewed your code and found no material issues that require review

Grey Divider

Qodo Logo

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

B-manager Selenium Manager C-rust Rust code is mostly Selenium Manager

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants