[rust] Improve SM error messages when browser/driver version not found#17584
Merged
Merged
Conversation
…ound Add per-browser links to canonical version lists in error messages so users know where to find valid versions when a lookup fails.
bonigarcia
approved these changes
May 29, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Closes #17555
When Selenium Manager cannot resolve a requested browser or driver version, the previous error messages were generic and gave users no guidance on where to find valid versions. This PR adds per-browser links to canonical version lists in all relevant error paths.
Changes per browser/driver:
https://googlechromelabs.github.io/chrome-for-testing/(already a constantCFT_URL)https://www.mozilla.org/en-US/firefox/releases/https://github.com/mozilla/geckodriver/releases/(already a constantDRIVER_URL)https://developer.microsoft.com/microsoft-edge/webdriver/https://github.com/SeleniumHQ/selenium/releases/(already a constantDRIVER_URL)Example before:
Example after:
Implementation approach:
get_browser_versions_url()default trait method (returns"") toSeleniumManagerthrow_error_message()appends the URL when non-empty (used byunavailable_download()andunavailable_discovery())download_browser()inlib.rsalso appends the URL to the minimum-version errorthrow_error_messageTest plan
//rust:unitpassesintegration_browser_download_tests_test,integration_stable_browser_tests_test) are pre-existing network-dependent download tests unrelated to this change