[build] only build debug artifacts when releasing#17595
Open
titusfortner wants to merge 1 commit into
Open
Conversation
Contributor
Review Summary by QodoGate Rust debug builds to release conditions only
WalkthroughsDescription• Gate debug artifact builds behind release conditions • Prevent unnecessary CI runs on PRs and forks • Align debug jobs with release job requirements • Reduce wasted CI minutes on discarded artifacts Diagramflowchart LR
A["Debug Build Jobs<br/>windows-debug<br/>linux-debug<br/>macos-debug"] -->|"Updated if condition"| B["Stricter Gate:<br/>not schedule AND<br/>not fork AND<br/>trunk or release"]
B -->|"Result"| C["Only run on:<br/>trunk pushes or<br/>manual release"]
File Changes1. .github/workflows/ci-rust.yml
|
Contributor
Code Review by Qodo
1. Duplicated release condition
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
🔗 Related Issues
Altnerative to #17590
First, we should verify what we are using these for in the first place, but I don't think we need to build the artifacts if we aren't going to save them to the artifacts repo.
💥 What does this PR do?
Gates the Rust debug binary builds (Windows, Linux, macOS) in
ci-rust.ymlbehind the same condition as thereleasejob, so they only run on trunk pushes with rust changes, or wheninputs.releaseis true