[py] run affected python tests per-browser on PR, full suite on schedule#17643
Open
titusfortner wants to merge 1 commit into
Open
[py] run affected python tests per-browser on PR, full suite on schedule#17643titusfortner wants to merge 1 commit into
titusfortner wants to merge 1 commit into
Conversation
Contributor
Review Summary by Qodo(Agentic_describe updated until commit 79bfb73)Run affected Python tests per-browser on PR, full suite on schedule
WalkthroughsDescription• Run only affected Python tests per-browser on PR, full suite on schedule • Pass target list from main CI workflow to Python workflow via inputs • Update rerun-failures script to handle bazel query results • Remove build job dependency for test jobs, keep only on schedule/manual • Use bazel query intersection to filter tests by affected targets Diagramflowchart LR
CI["ci.yml<br/>Read Targets"] -->|"py_targets"| PY["ci-python.yml<br/>Receive targets input"]
PY -->|"Schedule/Manual"| BUILD["Build Job"]
PY -->|"PR: affected only"| REMOTE["Remote Tests<br/>bazel query intersect"]
PY -->|"PR: affected only"| BROWSER["Browser Tests<br/>bazel query intersect"]
RERUN["rerun-failures.sh<br/>Parse query results"] -.->|"Enhanced"| REMOTE
RERUN -.->|"Enhanced"| BROWSER
File Changes1. scripts/github-actions/rerun-failures.sh
|
Contributor
Code Review by Qodo
1. Build job skips scheduled runs
|
![qodo-code-review[bot]](https://avatars.githubusercontent.com/in/484649?s=60&v=4){kind=small}
Contributor
|
Code review by qodo was updated up to the latest commit decdc1c |
3 tasks
titusfortner
force-pushed
the
py-affected-split
branch
from
decdc1c to
eb7cf50
Compare
Contributor
|
Code review by qodo was updated up to the latest commit eb7cf50 |
| jobs: | ||
| build: | ||
| name: Build | ||
| if: github.event_name == 'schedule' || github.event_name == 'workflow_dispatch' |
Contributor
There was a problem hiding this comment.
1. Build job skips scheduled runs 📘 Rule violation ☼ Reliability
In .github/workflows/ci-python.yml, both the build and unit-tests jobs are gated on github.event_name == 'schedule', but the workflow is only invoked via workflow_call/workflow_dispatch from .github/workflows/ci.yml, so on scheduled CI the called workflow’s event name is workflow_call and these jobs will be skipped. This can silently eliminate intended scheduled build and unit-test coverage and reduce CI safety.
Agent Prompt
## Issue description
In the reusable workflow `.github/workflows/ci-python.yml`, the `build` and `unit-tests` jobs are gated by `if: github.event_name == 'schedule' || github.event_name == 'workflow_dispatch'`. When this workflow is executed via `workflow_call` from `.github/workflows/ci.yml` (including scheduled runs), `github.event_name` in the called workflow evaluates to `workflow_call`, so these jobs are skipped unintentionally.
## Issue Context
`.github/workflows/ci.yml` is the workflow that triggers on `schedule` and calls `ci-python.yml` via `uses: ./.github/workflows/ci-python.yml`. The called workflow currently has no `schedule` trigger and thus cannot ever have `github.event_name == 'schedule'`; the condition in the called workflow therefore does not reflect the caller’s trigger and prevents the scheduled build and unit-test coverage from running.
## Fix Focus Areas
- .github/workflows/ci-python.yml[15-18]
- .github/workflows/ci-python.yml[48-61]
- .github/workflows/ci.yml[3-12]
- .github/workflows/ci.yml[121-128]
ⓘ Copy this prompt and use it to remediate the issue with your preferred AI generation tools
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
🔗 Related Issues
Part of #17539 to minimize low signal tests and duplication with RBE.
💥 What does this PR do?
Makes the Python GitHub Actions workflow run only the tests a PR or Push actually affects,
instead of the full suite on every PR. Continues to run existing tests on schedule/manual kickoff
ci.ymlnow passes the affected//pytarget list intoci-python.ymlto run only those targets for PRs and Pulls.[py]is specified in PR message or commit🔧 Implementation Notes
rerun-failures.shis shared infra (all bindings). The change is additive andbackward-compatible — it only affects run commands with a trailing
$(...), which no otherbinding uses today.
rerun-failures.shupdated to support analyzing query results🤖 AI assistance
ci.yml/ci-python.ymlworkflow changes and thererun-failures.shedit, iterated against repeated review.💡 Additional Considerations
bazel queryintersect to--test_tag_filtersafter implementing the necessary tags🔄 Types of changes