Skip to content

[build] Automated Browser Version Update#17646

Merged
diemol merged 1 commit into
trunkfrom
pinned-browser-updates
Jun 7, 2026
Merged

[build] Automated Browser Version Update#17646
diemol merged 1 commit into
trunkfrom
pinned-browser-updates

Conversation

@selenium-ci
Copy link
Copy Markdown
Member

This is an automated pull request to update pinned browsers and drivers

Merge after verifying the new browser versions are properly passing the tests

@selenium-ci selenium-ci added the B-build Includes scripting, bazel and CI integrations label Jun 6, 2026
@qodo-code-review
Copy link
Copy Markdown
Contributor

qodo-code-review Bot commented Jun 6, 2026

Code Review by Qodo

🐞 Bugs (1) 📘 Rule violations (0)

Grey Divider


Action required

1. Linux Edge driver mismatch 🐞 Bug ☼ Reliability
Description
This PR changes the pinned Linux EdgeDriver to 149.0.4022.50 while the pinned Linux Edge browser
remains 149.0.4022.52, creating a browser/driver build mismatch. EdgeDriver has an explicit
build-compatibility check (only bypassed when disable-build-check is set), so Linux Edge tests can
fail to start the driver by default.
Code

common/repositories.bzl[R168-169]

+        url = "https://msedgedriver.microsoft.com/149.0.4022.50/edgedriver_linux64.zip",
+        sha256 = "2eb8bc367f8de980490fbe0ce7d75d5ee6a92c475fabf4a9e1ec3355ac6c8094",
Evidence
The repository pins Linux Edge to 149.0.4022.52 but now pins Linux EdgeDriver to 149.0.4022.50
(while macOS EdgeDriver remains 149.0.4022.52), creating an inconsistent browser/driver set. The
Selenium Java EdgeDriverService explicitly documents build-version compatibility checks and a flag
to disable them, and the Ruby test harness only passes that flag when an environment variable is set
(i.e., not by default).

common/repositories.bzl[144-169]
common/repositories.bzl[183-186]
java/src/org/openqa/selenium/edge/EdgeDriverService.java[86-91]
java/src/org/openqa/selenium/edge/EdgeDriverService.java[184-193]
rb/spec/integration/selenium/webdriver/spec_support/test_environment.rb[315-321]
README.md[484-489]

Agent prompt
The issue below was found during a code review. Follow the provided context and guidance below and implement a solution

### Issue description
`linux_edgedriver` is pinned to a different build than `linux_edge` (driver 149.0.4022.50 vs browser 149.0.4022.52). Selenium/EdgeDriver includes a build compatibility check that is only bypassed when explicitly disabled, so this mismatch can prevent msedgedriver from starting in Linux Edge test runs.

### Issue Context
The pinned Linux Edge binary and its driver are consumed together by multiple Bazel test suites. The repo documents `DISABLE_BUILD_CHECK` as an opt-out for driver/browser mismatches, implying mismatches are not expected by default.

### Fix Focus Areas
- common/repositories.bzl[144-187]

### Suggested fix
- Pin `linux_edgedriver` to the same build as `linux_edge` (ideally 149.0.4022.52) and update its SHA256 accordingly.
- If the matching Linux EdgeDriver build is not available upstream, instead pin `linux_edge` (and mac pins if necessary) to a browser build that *does* have a matching EdgeDriver build, so browser+driver are aligned without requiring `DISABLE_BUILD_CHECK`.

ⓘ Copy this prompt and use it to remediate the issue with your preferred AI generation tools


Grey Divider

Previous review results

Review updated until commit 7ad8975

Results up to commit 260268f


🐞 Bugs (1) 📘 Rule violations (0) 📎 Requirement gaps (0) 🎨 UX issues (0)


Action required
1. Linux Edge driver mismatch 🐞 Bug ☼ Reliability
Description
This PR changes the pinned Linux EdgeDriver to 149.0.4022.50 while the pinned Linux Edge browser
remains 149.0.4022.52, creating a browser/driver build mismatch. EdgeDriver has an explicit
build-compatibility check (only bypassed when disable-build-check is set), so Linux Edge tests can
fail to start the driver by default.
Code

common/repositories.bzl[R168-169]

+        url = "https://msedgedriver.microsoft.com/149.0.4022.50/edgedriver_linux64.zip",
+        sha256 = "2eb8bc367f8de980490fbe0ce7d75d5ee6a92c475fabf4a9e1ec3355ac6c8094",
Evidence
The repository pins Linux Edge to 149.0.4022.52 but now pins Linux EdgeDriver to 149.0.4022.50
(while macOS EdgeDriver remains 149.0.4022.52), creating an inconsistent browser/driver set. The
Selenium Java EdgeDriverService explicitly documents build-version compatibility checks and a flag
to disable them, and the Ruby test harness only passes that flag when an environment variable is set
(i.e., not by default).

common/repositories.bzl[144-169]
common/repositories.bzl[183-186]
java/src/org/openqa/selenium/edge/EdgeDriverService.java[86-91]
java/src/org/openqa/selenium/edge/EdgeDriverService.java[184-193]
rb/spec/integration/selenium/webdriver/spec_support/test_environment.rb[315-321]
README.md[484-489]

Agent prompt
The issue below was found during a code review. Follow the provided context and guidance below and implement a solution

### Issue description
`linux_edgedriver` is pinned to a different build than `linux_edge` (driver 149.0.4022.50 vs browser 149.0.4022.52). Selenium/EdgeDriver includes a build compatibility check that is only bypassed when explicitly disabled, so this mismatch can prevent msedgedriver from starting in Linux Edge test runs.

### Issue Context
The pinned Linux Edge binary and its driver are consumed together by multiple Bazel test suites. The repo documents `DISABLE_BUILD_CHECK` as an opt-out for driver/browser mismatches, implying mismatches are not expected by default.

### Fix Focus Areas
- common/repositories.bzl[144-187]

### Suggested fix
- Pin `linux_edgedriver` to the same build as `linux_edge` (ideally 149.0.4022.52) and update its SHA256 accordingly.
- If the matching Linux EdgeDriver build is not available upstream, instead pin `linux_edge` (and mac pins if necessary) to a browser build that *does* have a matching EdgeDriver build, so browser+driver are aligned without requiring `DISABLE_BUILD_CHECK`.

ⓘ Copy this prompt and use it to remediate the issue with your preferred AI generation tools


Qodo Logo

Comment thread common/repositories.bzl Outdated
@qodo-code-review
Copy link
Copy Markdown
Contributor

qodo-code-review Bot commented Jun 6, 2026

Code review by qodo was updated up to the latest commit 7ad8975

@selenium-ci selenium-ci force-pushed the pinned-browser-updates branch from 7ad8975 to d1fa07a Compare June 7, 2026 01:25
@diemol diemol merged commit 7ca11b9 into trunk Jun 7, 2026
63 checks passed
@diemol diemol deleted the pinned-browser-updates branch June 7, 2026 09:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

B-build Includes scripting, bazel and CI integrations

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants