You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
This PR changes the pinned Linux EdgeDriver to 149.0.4022.50 while the pinned Linux Edge browser
remains 149.0.4022.52, creating a browser/driver build mismatch. EdgeDriver has an explicit
build-compatibility check (only bypassed when disable-build-check is set), so Linux Edge tests can
fail to start the driver by default.
The repository pins Linux Edge to 149.0.4022.52 but now pins Linux EdgeDriver to 149.0.4022.50
(while macOS EdgeDriver remains 149.0.4022.52), creating an inconsistent browser/driver set. The
Selenium Java EdgeDriverService explicitly documents build-version compatibility checks and a flag
to disable them, and the Ruby test harness only passes that flag when an environment variable is set
(i.e., not by default).
The issue below was found during a code review. Follow the provided context and guidance below and implement a solution
### Issue description
`linux_edgedriver` is pinned to a different build than `linux_edge` (driver 149.0.4022.50 vs browser 149.0.4022.52). Selenium/EdgeDriver includes a build compatibility check that is only bypassed when explicitly disabled, so this mismatch can prevent msedgedriver from starting in Linux Edge test runs.
### Issue Context
The pinned Linux Edge binary and its driver are consumed together by multiple Bazel test suites. The repo documents `DISABLE_BUILD_CHECK` as an opt-out for driver/browser mismatches, implying mismatches are not expected by default.
### Fix Focus Areas
- common/repositories.bzl[144-187]
### Suggested fix
- Pin `linux_edgedriver` to the same build as `linux_edge` (ideally 149.0.4022.52) and update its SHA256 accordingly.
- If the matching Linux EdgeDriver build is not available upstream, instead pin `linux_edge` (and mac pins if necessary) to a browser build that *does* have a matching EdgeDriver build, so browser+driver are aligned without requiring `DISABLE_BUILD_CHECK`.
ⓘ Copy this prompt and use it to remediate the issue with your preferred AI generation tools
This PR changes the pinned Linux EdgeDriver to 149.0.4022.50 while the pinned Linux Edge browser
remains 149.0.4022.52, creating a browser/driver build mismatch. EdgeDriver has an explicit
build-compatibility check (only bypassed when disable-build-check is set), so Linux Edge tests can
fail to start the driver by default.
The repository pins Linux Edge to 149.0.4022.52 but now pins Linux EdgeDriver to 149.0.4022.50
(while macOS EdgeDriver remains 149.0.4022.52), creating an inconsistent browser/driver set. The
Selenium Java EdgeDriverService explicitly documents build-version compatibility checks and a flag
to disable them, and the Ruby test harness only passes that flag when an environment variable is set
(i.e., not by default).
The issue below was found during a code review. Follow the provided context and guidance below and implement a solution
### Issue description
`linux_edgedriver` is pinned to a different build than `linux_edge` (driver 149.0.4022.50 vs browser 149.0.4022.52). Selenium/EdgeDriver includes a build compatibility check that is only bypassed when explicitly disabled, so this mismatch can prevent msedgedriver from starting in Linux Edge test runs.
### Issue Context
The pinned Linux Edge binary and its driver are consumed together by multiple Bazel test suites. The repo documents `DISABLE_BUILD_CHECK` as an opt-out for driver/browser mismatches, implying mismatches are not expected by default.
### Fix Focus Areas
- common/repositories.bzl[144-187]
### Suggested fix
- Pin `linux_edgedriver` to the same build as `linux_edge` (ideally 149.0.4022.52) and update its SHA256 accordingly.
- If the matching Linux EdgeDriver build is not available upstream, instead pin `linux_edge` (and mac pins if necessary) to a browser build that *does* have a matching EdgeDriver build, so browser+driver are aligned without requiring `DISABLE_BUILD_CHECK`.
ⓘ Copy this prompt and use it to remediate the issue with your preferred AI generation tools
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
B-buildIncludes scripting, bazel and CI integrations
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is an automated pull request to update pinned browsers and drivers
Merge after verifying the new browser versions are properly passing the tests