[dotnet] [bidi] Fix reflection based deserialization of additional data

[nvborisenko]

Fixes:

System.InvalidOperationException: Reflection-based serialization has been disabled for this application. Either use the source generator APIs or explicitly configure the 'JsonSerializerOptions.TypeInfoResolver' property.

🔗 Related Issues

💥 What does this PR do?

🔧 Implementation Notes

🤖 AI assistance

• No substantial AI assistance used
• AI assisted (complete below)
  • Tool(s):
  • What was generated:
  • I reviewed all AI output and can explain the change

💡 Additional Considerations

🔄 Types of changes

• Bug fix (backwards compatible)

[qodo-code-review]

Review Summary by Qodo

Fix BiDi reflection-based deserialization of additional data

🐞 Bug fix

Walkthroughs

Description

• Replace JsonSerializer.Deserialize with JsonElement.ParseValue
• Fixes reflection-based deserialization error in BiDi message processing
• Resolves disabled reflection serialization exception for additional data

Diagram

flowchart LR
  A["JsonSerializer.Deserialize<JsonElement>"] -->|"Replace with"| B["JsonElement.ParseValue"]
  B -->|"Result"| C["Reflection disabled error fixed"]

Loading

File Changes

1. dotnet/src/webdriver/BiDi/Broker.cs 🐞 Bug fix +1/-1

Replace JsonSerializer with JsonElement.ParseValue

• Changed deserialization method in ProcessReceivedMessage method
• Replaced JsonSerializer.Deserialize(ref reader) with JsonElement.ParseValue(ref reader)
• Fixes InvalidOperationException related to disabled reflection-based serialization
• Maintains same functionality while using reflection-safe API

dotnet/src/webdriver/BiDi/Broker.cs

---

[qodo-code-review]

Code Review by Qodo

🐞 Bugs (0) 📘 Rule violations (1) 📎 Requirement gaps (0)

Context used

✅ Tickets: 🎫 Instance ChroneDriver Error: ConnectFailure 🎫 2.48 doesn't trigger javascript in link's href on click()

1. ProcessReceivedMessage lacks regression test 📘 Rule violation ☼ Reliability

Description

ProcessReceivedMessage now parses additional top-level fields via `JsonElement.ParseValue(ref
reader)`, changing the message parsing behavior to address reflection-disabled serialization
scenarios. The PR does not add/update a test that exercises this reflection-disabled configuration,
increasing regression risk for the reported failure mode.

Code

dotnet/src/webdriver/BiDi/Broker.cs[266]

+                additionalMessageData[propName] = JsonElement.ParseValue(ref reader);

Evidence

PR Compliance ID 6 requires adding/updating tests for implemented fixes. The change at
Broker.cs:266 alters JSON parsing for additional message fields to address reflection-disabled
deserialization, but no corresponding test is added/updated to validate that this scenario works and
remains stable.

AGENTS.md: Add or Update Tests for Implemented Fixes and Prefer Small Unit Tests
dotnet/src/webdriver/BiDi/Broker.cs[263-267]
dotnet/test/webdriver/BiDi/SessionUnitTests.cs[119-127]

Agent prompt

The issue below was found during a code review. Follow the provided context and guidance below and implement a solution

## Issue description
The fix changes additional-data parsing to avoid reflection-based `JsonSerializer.Deserialize<JsonElement>(...)`, but there is no unit test that fails under `System.Text.Json` reflection-disabled mode and passes with the new parsing logic.

## Issue Context
The reported exception only happens when reflection-based serialization is disabled (common in AOT/trimming scenarios). Add a targeted unit test that toggles the relevant `AppContext` switch (and restores the prior value/state) and verifies that receiving a message with top-level additional fields does not throw and still populates `AdditionalMessageData`.

## Fix Focus Areas
- dotnet/src/webdriver/BiDi/Broker.cs[263-267]
- dotnet/test/webdriver/BiDi/SessionUnitTests.cs[119-127]

ⓘ Copy this prompt and use it to remediate the issue with your preferred AI generation tools

---