Fix for dotnet DriverService initialization#190
Closed
livioc wants to merge 1 commit intoSeleniumHQ:masterfrom
Closed
Fix for dotnet DriverService initialization#190livioc wants to merge 1 commit intoSeleniumHQ:masterfrom
livioc wants to merge 1 commit intoSeleniumHQ:masterfrom
Conversation
…driver service, added a minimal validation on the response of the 'status' command
livioc
changed the title
Contributor
Author
andreastt
added
Z-awaiting review
Member
|
Merged in b2483a1 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
DriverService will throw a WebDriverException if it cannot start the driver process so now it's more easy to debug if there's same problem during the driver initialization . Previous behaviour was to silently fail so client code will get errors only later when it will try to use the driver istance.
note: i used WebDriverException to have a consistent behaviour with the java code
note2: i do also a simply validation on the 'status' response to manage the case where the failure is caused explicitly setting a port that is already use by an http server (so the 'status' command can return a valid http response)