Fix Element::IsAttachedToDom() when used with SVG for IEDriver#28
Closed
paroga wants to merge 7 commits intoSeleniumHQ:masterfrom
Closed
Fix Element::IsAttachedToDom() when used with SVG for IEDriver#28paroga wants to merge 7 commits intoSeleniumHQ:masterfrom
paroga wants to merge 7 commits intoSeleniumHQ:masterfrom
Conversation
When the document is SVG instead of HTML the eventlistener for the unload event needs to be added to documentElement instead of body. This new function returns the corresponding element.
Some elements may not have a scrollIntoView function - for example, elements under an SVG element. Call those only if they exist.
If the document in the view is a SVG scrolling does not make much sense and resulting errors can be safely ignored.
SVG documents do not have a body attribute. Check for its existence before accessing it.
When used with an SVG document the script element must be created slightly different to work correctly. Fixes issue SeleniumHQ#1276.
Contributor
Author
|
@jimevans can you commit this pull request? |
Member
|
I could, if I agreed with how it was coded. I've had incredibly bad luck with |
Contributor
Author
|
Do you have an better solution for supporting SVG documents in IE? |
Member
|
No, there are no specific test cases. I ran into my issues when experimenting with removing the JavaScript automation atoms to attempt improving performance. So in a sense, the tests in ChildrenFindingTest.java exhibited problem when using contains(). |
Member
|
Merged in 6392601 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The first commits are already in #27.
CLA signed