Skip to content

Changed 'false' to 'False' to be in compliance with Python syntax in IDE webdriver export#33

Closed
flyte wants to merge 1 commit intoSeleniumHQ:masterfrom
flyte:master
Closed

Changed 'false' to 'False' to be in compliance with Python syntax in IDE webdriver export#33
flyte wants to merge 1 commit intoSeleniumHQ:masterfrom
flyte:master

Conversation

@flyte
Copy link
Copy Markdown

@flyte flyte commented Mar 19, 2013

Went to fix a similar bug in the same file with 'true' instead of 'True' which had already been fixed. I did, however, find a 'false' which should have been a 'False'. I haven't confirmed this as a bug, but I'm reasonably sure that it needs fixing.

@flyte
Copy link
Copy Markdown
Author

flyte commented Mar 19, 2013

I have signed the CLA.

@rajeevprabhakaran
Copy link
Copy Markdown

hi @flyte "Went to fix a similar bug in the same file with 'true' instead of 'True' which had already been fixed" << i am using latest IDE. It's not fixed am still seeing true instead of True.

Regards

@flyte
Copy link
Copy Markdown
Author

flyte commented Mar 19, 2013

Hi @rajeevprabhakaran
Yes, I thought that as well, but I can't find the bug in the source on git! I assumed it had been fixed already. Not sure how this project is packaged up, or where the versioning is done so I don't know whether I'm using this code (installed from pip) or an older version.
I've made a lot of assumptions, but to be honest I figured this was such a tiny fix that I could get away with it.. :)

@flyte
Copy link
Copy Markdown
Author

flyte commented Mar 19, 2013

It seems to be the case that the git IDE is v2.0.0 but I'm using v1.10.0. I could be wrong, but that's what it says in https://github.com/SeleniumHQ/selenium/blob/master/ide/install.rdf

@rajeevprabhakaran
Copy link
Copy Markdown

Hi @flyte - i am not sure...is this version is not yet available for public? i am also using v1.10.0.1...

http://i.imagebanana.com/img/2jovag66/Selection_173.png

Regards

@lukeis
Copy link
Copy Markdown
Member

lukeis commented Apr 8, 2013

merged in revision 0a6993c

@lukeis lukeis closed this Apr 8, 2013
yiming-tang-cs pushed a commit to ponder-lab/selenium that referenced this pull request Jan 2, 2020
Fix handling of unsupported compression methods - avoid NullPointerexception
yiming-tang-cs pushed a commit to ponder-lab/selenium that referenced this pull request Jan 2, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants