Fixing issue #4390 Element cannot be scrolled into view for FF#51
Merged
selenium-ci merged 1 commit intoSeleniumHQ:masterfrom Apr 17, 2013
alex-savchuk:upstream4
Merged
Fixing issue #4390 Element cannot be scrolled into view for FF#51selenium-ci merged 1 commit intoSeleniumHQ:masterfrom alex-savchuk:upstream4
selenium-ci merged 1 commit intoSeleniumHQ:masterfrom
alex-savchuk:upstream4
Conversation
Fixed issue #4390 for FF. Test case input is updated to cover FF fix.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixing issue #4390 Element cannot be scrolled into view for FF.
Test case input is updated to cover FF fix.
CLA as Alex Savchuk is signed.
P.S.: i'd fix it at bot.dom.getInViewLocation in comparison of coords before and after scrolling
but i'm not sure it doesn't broke something at another point.