Allow access to local profiler logs.#561
Closed
joshbruning wants to merge 1 commit intoSeleniumHQ:masterfrom
joshbruning:logging
Closed
Allow access to local profiler logs.#561joshbruning wants to merge 1 commit intoSeleniumHQ:masterfrom joshbruning:logging
joshbruning wants to merge 1 commit intoSeleniumHQ:masterfrom
joshbruning:logging
Conversation
Contributor
|
Please drop commits touching the unrelated sizzle.h. Make the pull request contains one commit. |
Contributor
|
..would be good to add. |
An exception may be thrown if the WebDriver server does not recognize profiler logs. In this case, the user should be able to see the local profiler logs.
Contributor
Author
|
Thanks - I've dropped the unrelated commits. If you could please take a look at #596, I would like to submit that first, and then I would be happy to add the relevant unit test to this pull request. |
Contributor
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
An exception may be thrown if the WebDriver server does
not recognize profiler logs. In this case, the user
should be able to see the local profiler logs.