Skip to content

Allow access to local profiler logs.#561

Closed
joshbruning wants to merge 1 commit intoSeleniumHQ:masterfrom
joshbruning:logging
Closed

Allow access to local profiler logs.#561
joshbruning wants to merge 1 commit intoSeleniumHQ:masterfrom
joshbruning:logging

Conversation

@joshbruning
Copy link
Copy Markdown
Contributor

An exception may be thrown if the WebDriver server does
not recognize profiler logs. In this case, the user
should be able to see the local profiler logs.

@sevaseva
Copy link
Copy Markdown
Contributor

Please drop commits touching the unrelated sizzle.h. Make the pull request contains one commit.
A unit (or large) test for this would be to add.

@sevaseva
Copy link
Copy Markdown
Contributor

..would be good to add.

An exception may be thrown if the WebDriver server does
not recognize profiler logs. In this case, the user
should be able to see the local profiler logs.
@joshbruning
Copy link
Copy Markdown
Contributor Author

Thanks - I've dropped the unrelated commits. If you could please take a look at #596, I would like to submit that first, and then I would be happy to add the relevant unit test to this pull request.

@sevaseva
Copy link
Copy Markdown
Contributor

Thanks. I merged #596 and this as edc4877. Please add unit tests for this in a separate commit.

@sevaseva sevaseva closed this Jun 16, 2015
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants