Log out responses received from RemoteWebDriver.#726
Closed
DylanLacey wants to merge 1 commit intoSeleniumHQ:masterfrom
DylanLacey:master
Closed
Log out responses received from RemoteWebDriver.#726DylanLacey wants to merge 1 commit intoSeleniumHQ:masterfrom DylanLacey:master
DylanLacey wants to merge 1 commit intoSeleniumHQ:masterfrom
DylanLacey:master
Conversation
Expanded the response from a RemoteWebDriver call to include the response, as returned by `.getValue()`.
Member
|
the only problem I have with this is it's potentially going to flood logs, as this will also include the responses to page_source and screenshots. |
|
|
Member
|
Thanks for the patch. We are not going to bring it in as we are looking to review all of our logging in the future as it can be quite verbose. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Expanded the response from a RemoteWebDriver call to include the
response, as returned by
.getValue().This change is