Skip to content

Log out responses received from RemoteWebDriver.#726

Closed
DylanLacey wants to merge 1 commit intoSeleniumHQ:masterfrom
DylanLacey:master
Closed

Log out responses received from RemoteWebDriver.#726
DylanLacey wants to merge 1 commit intoSeleniumHQ:masterfrom
DylanLacey:master

Conversation

@DylanLacey
Copy link
Copy Markdown
Contributor

@DylanLacey DylanLacey commented Jul 2, 2015

Expanded the response from a RemoteWebDriver call to include the
response, as returned by .getValue().


This change is Reviewable

Expanded the response from a RemoteWebDriver call to include the
response, as returned by `.getValue()`.
@ddavison ddavison added Z-awaiting review Archived: use GitHub review assignments C-java Java Bindings labels Jul 2, 2015
@lukeis
Copy link
Copy Markdown
Member

lukeis commented Jul 2, 2015

the only problem I have with this is it's potentially going to flood logs, as this will also include the responses to page_source and screenshots.

@CLAassistant
Copy link
Copy Markdown

CLAassistant commented Nov 23, 2019

CLA assistant check
All committers have signed the CLA.

@CLAassistant
Copy link
Copy Markdown

CLA assistant check
Thank you for your submission, we really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.
You have signed the CLA already but the status is still pending? Let us recheck it.

@AutomatedTester
Copy link
Copy Markdown
Member

Thanks for the patch. We are not going to bring it in as we are looking to review all of our logging in the future as it can be quite verbose.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

C-java Java Bindings Z-awaiting review Archived: use GitHub review assignments

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants