Skip to content

Conversation

@harsha509
Copy link
Member

@harsha509 harsha509 commented Feb 18, 2020

Description

Adding new document for webdriver -> page load strategy with Java and JS code examples

Types of changes

  • Change to the site (I am attaching a screenshot showing the before and after)
  • Code example added (and I also added the example to all translated languages)
  • Improved translation
  • Added new translation (and I also added a notice to each document missing translation)

Checklist

  • I have read the contributing document.
  • I have used hugo to render the site/docs locally and I am sure it works.

@harsha509 harsha509 requested a review from diemol February 18, 2020 16:48
Copy link
Member

@diemol diemol left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you @harsha509, I left a few minor comments.
Also, can you please check if the strategies work both in Chrome and Firefox at least? I remember that both browsers did not support all of them.

@harsha509
Copy link
Member Author

Thank you @harsha509, I left a few minor comments.
Also, can you please check if the strategies work both in Chrome and Firefox at least? I remember that both browsers did not support all of them.

Hi @diemol,

Thanks for the update. I have tested the code samples in chrome only. Will check in firefox and will provide the update.

Also will update the suggested changes.

Regards,
Harsha

@harsha509
Copy link
Member Author

Hi @diemol,

I've tested the code sample with firefox 70.0.1 with selenium4-alpha-5 JS bindings and it worked as expected.

Please let me know if any additional info is required.

Regards,
Harsha

Copy link
Member

@diemol diemol left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for double-checking @harsha509!

@harsha509
Copy link
Member Author

Thanks for reviewing @diemol.

@diemol diemol merged commit 0c83c87 into SeleniumHQ:master Feb 20, 2020
@harsha509 harsha509 deleted the page_load_strategy branch February 21, 2020 06:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants