Bug: Defer Disconnect Teardown#222
Merged
Merged
Conversation
|
The latest updates on your projects. Learn more about Vercel for GitHub.
1 Skipped Deployment
|
jlukic
force-pushed
the
bug/hydrate-disconnect
branch
from
41a02cc to
04b113b
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Discovered while debugging icons in the docs sidebar appearing then disappearing ~500ms after page load.
A move (remove + reinsert in the same task) fires disconnect+connect on a custom element. Treating that as a removal destroys live nested components mid-move. Latent since the native renderer landed, observable after #201.
Changes
Risk
7/10. Disconnect teardown timing goes from synchronous to microtask-deferred for every component.
Failure modes:
removeChildwill need toawaita microtask before the assertion.