Re-append kimik2.5-int4-b300-vllm changelog entry#1269
Conversation
Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
|
Thanks for the contribution! For vLLM & SGLang, please ensure that your recipes is similar to the official vLLM recipes and/or the SGLang cookbook If it is not, please create a PR first before we can merge your PR into the master branch. Let's ensure that the documentation is first class such that the entire ML community can benefit from your hard work! Thank you PR authors are responsible for ensuring that after merging, all GitHub Action jobs fully pass. A lot of the time, failures are just flakes and simply re-running the failed jobs will fix it. If re-running failed jobs is attempted, PR authors are responsible for ensuring it passes. See GitHub's docs on re-running failed jobs: https://docs.github.com/en/actions/how-tos/manage-workflow-runs/re-run-workflows-and-jobs#re-running-failed-jobs-in-a-workflow As a rule of thumb, generally, PR authors should request a review & get a PR approval from the respective companies' CODEOWNERS before requesting a review from core maintainers. If additional help is needed, PR authors can reach out to core maintainers over Slack. |
There was a problem hiding this comment.
LGTM — mechanical re-append of an existing changelog entry to retrigger the sweep workflow that GITHUB_TOKEN-driven auto-merge skipped.
Extended reasoning...
Overview
This PR appends 9 lines to the bottom of perf-changelog.yaml — a duplicate of the kimik2.5-int4-b300-vllm entry already merged in #1267 (and referencing the same originating PR #1057). The added block is byte-identical to the existing entry near line 2125 of the file.
Security risks
None. The change is a YAML data-only edit to a changelog file with no executable code, no secrets, no permissions surface, and no auth-relevant behavior.
Level of scrutiny
Low. The change is mechanical, self-contained, and the rationale is clearly documented in the PR description: GitHub Actions does not fire downstream workflows for pushes created by GITHUB_TOKEN (which is what auto-merge used for #1267), so run-sweep.yml did not trigger and no benchmark ran. Re-appending the entry produces a fresh diff so process_changelog.py picks the config back up.
Other factors
The bug hunting system found no issues. There are no outstanding reviewer comments other than the standard github-actions[bot] recipe-reminder template that is posted on every PR. The PR touches only a single file with no logic changes, and a duplicate-entry approach is the conventional workaround for this GitHub Actions limitation.
Co-authored-by: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
#1293) PR #1276 ("Tune MiniMax MI355X vLLM scheduling thresholds") landed without a perf-changelog entry — the prepared entry was dropped in commit 8d8b1e0 ("Remove MiniMax perf changelog entry") before merge, so the tuned recipe never re-ran on push-to-main and the dashboard still reflects the old launch policy. Re-add the entry so a sweep is triggered for the new policy and the change is documented chronologically. The entry references the original PR #1276, matching the convention used for prior changelog re-appends (e.g. #1269). Co-authored-by: Cursor <cursoragent@cursor.com>
Summary
Re-appends the
kimik2.5-int4-b300-vllmchangelog entry at the bottom ofperf-changelog.yaml. The entry is identical to the one merged in #1267.The auto-merge of #1267 was performed by GitHub's internal
web-flowuser, and per GitHub Actions' documented security policy, push events created byGITHUB_TOKENdo not trigger downstream workflows. As a result,run-sweep.ymldid not fire for the merge commit (9c7fb6f3) and no benchmark sweep ran for the new config. This duplicate entry produces a fresh diff againstperf-changelog.yamlsoprocess_changelog.pypicks the config back up and the sweep runs.🤖 Generated with Claude Code