Update minimaxm2.5-fp8-h200-vllm vLLM image to v0.21.0#1402
Conversation
Ref #1154 Co-authored-by: Klaud Cold <Klaud-Cold@users.noreply.github.com>
|
Thanks for the contribution! For vLLM & SGLang, please ensure that your recipes is similar to the official vLLM recipes and/or the SGLang cookbook If it is not, please create a PR first before we can merge your single node PR into the master branch. Let's ensure that the documentation is first class such that the entire ML community can benefit from your hard work! Thank you PR authors are responsible for ensuring that after merging, all GitHub Action jobs fully pass. A lot of the time, failures are just flakes and simply re-running the failed jobs will fix it. If re-running failed jobs is attempted, PR authors are responsible for ensuring it passes. See GitHub's docs on re-running failed jobs: https://docs.github.com/en/actions/how-tos/manage-workflow-runs/re-run-workflows-and-jobs#re-running-failed-jobs-in-a-workflow As a rule of thumb, generally, PR authors should request a review & get a PR approval from the respective companies' CODEOWNERS before requesting a review from core maintainers. If additional help is needed, PR authors can reach out to core maintainers over Slack. |
|
see unofficial run visualizer at https://inferencex.semianalysis.com/inference?unofficialRun=25956500343 |
| - minimaxm2.5-fp8-h200-vllm | ||
| description: | ||
| - "Update vLLM image from v0.20.2 to v0.21.0" | ||
| pr-link: XXX |
There was a problem hiding this comment.
🟡 The new perf-changelog.yaml entry has pr-link: XXX instead of an actual PR URL. All ~250 other entries use a fully qualified GitHub PR URL — this should be replaced with https://github.com/SemiAnalysisAI/InferenceX/pull/1402 to preserve traceability.
Extended reasoning...
What the bug is
In perf-changelog.yaml at line 2501, the newly added changelog entry for minimaxm2.5-fp8-h200-vllm has pr-link: XXX as its value. XXX is clearly an unfilled placeholder that was left in by accident — it is not a real GitHub URL.
Why this matters
Every other entry in perf-changelog.yaml (around 250 entries) uses a fully qualified GitHub PR URL of the form https://github.com/SemiAnalysisAI/InferenceX/pull/<N>. For example, the immediately preceding entry on line 2495 uses https://github.com/SemiAnalysisAI/InferenceX/pull/1271. The whole point of the pr-link field is to provide traceability from a performance change back to the PR that introduced it. With XXX in place, this entry has no traceability whatsoever.
Code path
The diff adds the following entry at the end of perf-changelog.yaml:
- config-keys:
- minimaxm2.5-fp8-h200-vllm
description:
- "Update vLLM image from v0.20.2 to v0.21.0"
pr-link: XXXThe XXX is a literal string left from the author's template, not a valid URL.
Step-by-step proof
- Open
perf-changelog.yamlat line 2501. - Observe the value:
pr-link: XXX. - Compare against line 2495:
pr-link: https://github.com/SemiAnalysisAI/InferenceX/pull/1271. - Compare against any other entry in the file — all use the
https://github.com/SemiAnalysisAI/InferenceX/pull/<N>format. - Confirm via PR metadata: this PR is Update minimaxm2.5-fp8-h200-vllm vLLM image to v0.21.0 #1402.
- Conclusion:
XXXis an unfilled placeholder and the correct value ishttps://github.com/SemiAnalysisAI/InferenceX/pull/1402.
How to fix
Replace pr-link: XXX with pr-link: https://github.com/SemiAnalysisAI/InferenceX/pull/1402.
Impact
This is metadata only, with no runtime impact. It is a documentation/traceability defect — hence nit severity — but it is trivially fixable and should be corrected before merge to keep the changelog consistent with every other entry.
|
see unofficial run visualizer at https://inferencex.semianalysis.com/inference?unofficialRun=25956500512 |
|
/reuse-sweep-run |
|
see unofficial run visualizer at https://inferencex.semianalysis.com/inference?unofficialRun=25979762753 |
Summary
minimaxm2.5-fp8-h200-vllmfrom v0.20.2 to v0.21.0.Ref #1154
Generated with Claude Code