Skip to content

Update minimaxm2.5-fp8-h200-vllm vLLM image to v0.21.0#1402

Merged
functionstackx merged 2 commits into
mainfrom
claude/issue-1154-minimaxm2.5-fp8-h200-vllm
May 17, 2026
Merged

Update minimaxm2.5-fp8-h200-vllm vLLM image to v0.21.0#1402
functionstackx merged 2 commits into
mainfrom
claude/issue-1154-minimaxm2.5-fp8-h200-vllm

Conversation

@Klaud-Cold
Copy link
Copy Markdown
Collaborator

Summary

  • Updates the vLLM image tag for minimaxm2.5-fp8-h200-vllm from v0.20.2 to v0.21.0.

Ref #1154

Generated with Claude Code

Ref #1154

Co-authored-by: Klaud Cold <Klaud-Cold@users.noreply.github.com>
@github-actions
Copy link
Copy Markdown
Contributor

Thanks for the contribution! For vLLM & SGLang, please ensure that your recipes is similar to the official vLLM recipes and/or the SGLang cookbook

If it is not, please create a PR first before we can merge your single node PR into the master branch. Let's ensure that the documentation is first class such that the entire ML community can benefit from your hard work! Thank you

PR authors are responsible for ensuring that after merging, all GitHub Action jobs fully pass. A lot of the time, failures are just flakes and simply re-running the failed jobs will fix it. If re-running failed jobs is attempted, PR authors are responsible for ensuring it passes. See GitHub's docs on re-running failed jobs: https://docs.github.com/en/actions/how-tos/manage-workflow-runs/re-run-workflows-and-jobs#re-running-failed-jobs-in-a-workflow

As a rule of thumb, generally, PR authors should request a review & get a PR approval from the respective companies' CODEOWNERS before requesting a review from core maintainers.

If additional help is needed, PR authors can reach out to core maintainers over Slack.

@github-actions
Copy link
Copy Markdown
Contributor

Comment thread perf-changelog.yaml Outdated
- minimaxm2.5-fp8-h200-vllm
description:
- "Update vLLM image from v0.20.2 to v0.21.0"
pr-link: XXX
Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🟡 The new perf-changelog.yaml entry has pr-link: XXX instead of an actual PR URL. All ~250 other entries use a fully qualified GitHub PR URL — this should be replaced with https://github.com/SemiAnalysisAI/InferenceX/pull/1402 to preserve traceability.

Extended reasoning...

What the bug is

In perf-changelog.yaml at line 2501, the newly added changelog entry for minimaxm2.5-fp8-h200-vllm has pr-link: XXX as its value. XXX is clearly an unfilled placeholder that was left in by accident — it is not a real GitHub URL.

Why this matters

Every other entry in perf-changelog.yaml (around 250 entries) uses a fully qualified GitHub PR URL of the form https://github.com/SemiAnalysisAI/InferenceX/pull/<N>. For example, the immediately preceding entry on line 2495 uses https://github.com/SemiAnalysisAI/InferenceX/pull/1271. The whole point of the pr-link field is to provide traceability from a performance change back to the PR that introduced it. With XXX in place, this entry has no traceability whatsoever.

Code path

The diff adds the following entry at the end of perf-changelog.yaml:

- config-keys:
    - minimaxm2.5-fp8-h200-vllm
  description:
    - "Update vLLM image from v0.20.2 to v0.21.0"
  pr-link: XXX

The XXX is a literal string left from the author's template, not a valid URL.

Step-by-step proof

  1. Open perf-changelog.yaml at line 2501.
  2. Observe the value: pr-link: XXX.
  3. Compare against line 2495: pr-link: https://github.com/SemiAnalysisAI/InferenceX/pull/1271.
  4. Compare against any other entry in the file — all use the https://github.com/SemiAnalysisAI/InferenceX/pull/<N> format.
  5. Confirm via PR metadata: this PR is Update minimaxm2.5-fp8-h200-vllm vLLM image to v0.21.0 #1402.
  6. Conclusion: XXX is an unfilled placeholder and the correct value is https://github.com/SemiAnalysisAI/InferenceX/pull/1402.

How to fix

Replace pr-link: XXX with pr-link: https://github.com/SemiAnalysisAI/InferenceX/pull/1402.

Impact

This is metadata only, with no runtime impact. It is a documentation/traceability defect — hence nit severity — but it is trivially fixable and should be corrected before merge to keep the changelog consistent with every other entry.

@github-actions
Copy link
Copy Markdown
Contributor

@functionstackx
Copy link
Copy Markdown
Collaborator

/reuse-sweep-run

@functionstackx functionstackx merged commit 40f8c47 into main May 17, 2026
3 of 4 checks passed
@functionstackx functionstackx deleted the claude/issue-1154-minimaxm2.5-fp8-h200-vllm branch May 17, 2026 03:03
@github-actions
Copy link
Copy Markdown
Contributor

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

Development

Successfully merging this pull request may close these issues.

2 participants