Skip to content

Update qwen3.5-bf16-b300-sglang and -mtp SGLang image to v0.5.12-cu130 #1422

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
Klaud-Cold wants to merge 1 commit into
base: main
Choose a base branch
from
+9 −2
Open

Update qwen3.5-bf16-b300-sglang and -mtp SGLang image to v0.5.12-cu130 #1422

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions .github/configs/nvidia-master.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2396,7 +2396,7 @@ qwen3.5-fp4-b300-sglang-mtp:
- { tp: 2, ep: 2, conc-start: 4, conc-end: 128, spec-decoding: mtp }

qwen3.5-bf16-b300-sglang:
image: lmsysorg/sglang:v0.5.11-cu130
image: lmsysorg/sglang:v0.5.12-cu130
model: Qwen/Qwen3.5-397B-A17B
model-prefix: qwen3.5
runner: b300
Expand All @@ -2417,7 +2417,7 @@ qwen3.5-bf16-b300-sglang:
- { tp: 4, ep: 1, conc-start: 4, conc-end: 64 }

qwen3.5-bf16-b300-sglang-mtp:
image: lmsysorg/sglang:v0.5.11-cu130
image: lmsysorg/sglang:v0.5.12-cu130
model: Qwen/Qwen3.5-397B-A17B
model-prefix: qwen3.5
runner: b300
Expand Down
7 changes: 7 additions & 0 deletions perf-changelog.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2548,3 +2548,10 @@
description:
- "Update vLLM image from v0.20.2 to v0.21.0"
pr-link: https://github.com/SemiAnalysisAI/InferenceX/pull/1402

- config-keys:
- qwen3.5-bf16-b300-sglang
- qwen3.5-bf16-b300-sglang-mtp
description:
- "Update SGLang image from v0.5.11-cu130 to v0.5.12-cu130"
pr-link: XXX

Check failure on line 2557 in perf-changelog.yaml

View check run for this annotation

Claude / Claude Code Review

perf-changelog pr-link placeholder not filled in 

The new perf-changelog entry uses the literal placeholder `pr-link: XXX` instead of the actual PR URL. All other entries in this file follow the canonical format `pr-link: https://github.com/SemiAnalysisAI/InferenceX/pull/<num>`, so this should be `https://github.com/SemiAnalysisAI/InferenceX/pull/1422` before merging.
Copy link
Copy Markdown
Contributor

@claude claude Bot May 17, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🔴 The new perf-changelog entry uses the literal placeholder pr-link: XXX instead of the actual PR URL. All other entries in this file follow the canonical format pr-link: https://github.com/SemiAnalysisAI/InferenceX/pull/<num>, so this should be https://github.com/SemiAnalysisAI/InferenceX/pull/1422 before merging.

Extended reasoning...

What the bug is

The diff adds a new entry to perf-changelog.yaml at line 2557 with pr-link: XXX. The string XXX is clearly an unfilled template placeholder that was supposed to be replaced with the actual PR URL before opening this PR.

How it manifests

Every prior entry in perf-changelog.yaml follows the same convention. Looking at the four most recent entries that come immediately before this one (lines 2532, 2538, 2544, 2550), each uses the canonical format:

pr-link: https://github.com/SemiAnalysisAI/InferenceX/pull/<num>

The new entry breaks this pattern by retaining a template placeholder.

Step-by-step proof

  1. Open perf-changelog.yaml and look at the four most recent entries that come immediately before the newly added block:
    • Line 2532: pr-link: https://github.com/SemiAnalysisAI/InferenceX/pull/...
    • Line 2538: pr-link: https://github.com/SemiAnalysisAI/InferenceX/pull/...
    • Line 2544: pr-link: https://github.com/SemiAnalysisAI/InferenceX/pull/...
    • Line 2550: pr-link: https://github.com/SemiAnalysisAI/InferenceX/pull/1402
  2. The new entry added by this PR ends at line 2557 with: pr-link: XXX
  3. XXX is not a URL and does not match the established pattern.
  4. This PR is Update qwen3.5-bf16-b300-sglang and -mtp SGLang image to v0.5.12-cu130 #1422, so the value should be https://github.com/SemiAnalysisAI/InferenceX/pull/1422.

Why existing code doesn't prevent it

The changelog convention is enforced by author discipline rather than by a schema check — YAML happily parses XXX as a string, so neither YAML validation nor any current CI step rejects the placeholder. The PR description even references #1154 as context, but the changelog placeholder was never filled in.

Impact

Any link-following automation, release-notes generator, or human reader navigating the changelog will hit a dead string (XXX) instead of a real PR link for this entry. While the file still parses, the structured pr-link field becomes useless for this row and breaks the documented convention going forward.

How to fix

Replace line 2557 with:

  pr-link: https://github.com/SemiAnalysisAI/InferenceX/pull/1422

Loading