Skip to content

[Handoff to @Oseltamivir Claude /loop] [Klaud Cold] Update dsv4-fp4-b200-sglang SGLang image to v0.5.12-cu130 #1450

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
functionstackx wants to merge 2 commits into
base: main
Choose a base branch
from
+10,890 −1
Open

[Handoff to @Oseltamivir Claude /loop] [Klaud Cold] Update dsv4-fp4-b200-sglang SGLang image to v0.5.12-cu130 #1450

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
01c145a
Update dsv4-fp4-b200-sglang SGLang image to v0.5.12-cu130
functionstackx May 17, 2026
f93b9c5
chore: fill pr-link for #1450
functionstackx May 17, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion .github/configs/nvidia-master.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1696,7 +1696,7 @@ dsr1-fp4-b200-sglang:
- { tp: 8, ep: 8, offloading: none, conc-list: [1, 2, 4, 8, 12, 16, 32, 64, 128, 256, 512] }

dsv4-fp4-b200-sglang:
image: lmsysorg/sglang:deepseek-v4-blackwell@sha256:df18bfc4aa9ecf59451002b49ba00cae58042de9e2a96378bbd21b404dd62c7b
image: lmsysorg/sglang:v0.5.12-cu130
Copy link
Copy Markdown
Contributor

@claude claude Bot May 17, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🟡 This image bump silences the runner conditional and stale TODO in runners/launch_b200-{cw,nb,dgxc}.sh and benchmarks/single_node/dsv4_fp4_b200.sh:31-35 that explicitly said "Drop the runner conditional once lmsys moves sglang back out of /workspace" — v0.5.12-cu130 is exactly that trigger, but the cleanup wasn't done, leaving four dead if [[ "$IMAGE" == *deepseek-v4-blackwell* ]] branches and five stale TODOs referencing an unused tag. Functionally low-risk since sibling b200 recipes (nvidia-master.yaml:1852,1938,1961,…) already run v0.5.12-cu130 against the default /workspace mount, but worth confirming v0.5.12-cu130 installs sglang under /sgl-workspace (not /workspace) and then removing the now-dead conditional + TODOs in this PR.

Extended reasoning...

What the bug is

This PR replaces the SHA-pinned lmsysorg/sglang:deepseek-v4-blackwell image with lmsysorg/sglang:v0.5.12-cu130 for dsv4-fp4-b200-sglang. After this change, no recipe in .github/configs/nvidia-master.yaml uses the deepseek-v4-blackwell tag anymore (grep on the post-PR tree returns no matches outside the launchers themselves).

But the runner scripts still carry conditional branches gated on that exact tag:

  • runners/launch_b200-cw.sh:27 — if [[ "$IMAGE" == *deepseek-v4-blackwell* ]]; then CONTAINER_MOUNT_DIR=/ix
  • runners/launch_b200-nb.sh:23 — same
  • runners/launch_b200-dgxc.sh:351 — same
  • runners/launch_b300-nv.sh:314 — broader pattern, the *deepseek-v4-blackwell* arm is dead but *deepseek-v4-b300*/*sglang-b300* arms still match other recipes

Plus five TODO comments (launch_b200-cw.sh:22-26, launch_b200-nb.sh:18-22, launch_b200-dgxc.sh:346-350, launch_b300-nv.sh:308-313, benchmarks/single_node/dsv4_fp4_b200.sh:31-35) describing the special /ix mount handling. The bench-script TODO is most explicit:

Drop the runner conditional once lmsys moves sglang back out of /workspace.

That is exactly the event this PR represents, but the cleanup wasn't performed.

Step-by-step proof

  1. Before this PR: dsv4-fp4-b200-sglang uses lmsysorg/sglang:deepseek-v4-blackwell@sha256:…. When a job runs on b200-dsv4 and launch_b200-cw.sh evaluates if [[ "$IMAGE" == *deepseek-v4-blackwell* ]], it matches → CONTAINER_MOUNT_DIR=/ix → repo is mounted at /ix, leaving the editable sglang install at /workspace/sglang/python visible.
  2. After this PR: $IMAGE becomes lmsysorg/sglang:v0.5.12-cu130. The conditional no longer matches → CONTAINER_MOUNT_DIR=/workspace (default). For the recipe to keep working, v0.5.12-cu130 must not install sglang under /workspace (otherwise the bind-mount would mask the install).
  3. Evidence that v0.5.12-cu130 is safe with the default /workspace mount: nine other recipes in nvidia-master.yaml already use lmsysorg/sglang:v0.5.12-cu130 (lines 1852, 1938, 1961, 2290, 2311, 2708, 2731, 2825) on b200 launchers without an /ix override, so the released v0.5.12-cu130 evidently installs sglang at /sgl-workspace/sglang as the TODO implies. The recipe should still function.
  4. Therefore: the conditional and TODOs are now dead code. The *deepseek-v4-blackwell* arm of the b300 launcher is also unreachable (no recipe uses that tag).

Impact and fix

Low functional risk — the recipe will almost certainly still pass the sweep, since sibling recipes prove v0.5.12-cu130 works with the default mount. The cost is technical-debt drift: future readers will see TODOs whose precondition has already been met and a conditional whose match arm is never exercised. The PR's own description warns about possible incompat, which is why pulling these guards out should ideally be paired with sweep validation.

Suggested cleanup for this PR (or an immediate follow-up):

  • Remove the if [[ "$IMAGE" == *deepseek-v4-blackwell* ]] branch and its TODO in runners/launch_b200-cw.sh, runners/launch_b200-nb.sh, and runners/launch_b200-dgxc.sh (replace with a single unconditional CONTAINER_MOUNT_DIR=/workspace line, or drop the variable entirely if the default suffices).
  • In runners/launch_b300-nv.sh:314, drop just the *deepseek-v4-blackwell* arm of the disjunction; keep the others.
  • Remove the TODO at benchmarks/single_node/dsv4_fp4_b200.sh:31-35 — its premise no longer holds.

model: deepseek-ai/DeepSeek-V4-Pro
model-prefix: dsv4
runner: b200-dsv4
Expand Down
6 changes: 6 additions & 0 deletions perf-changelog.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2629,3 +2629,9 @@
description:
- "Update vLLM ROCm image from v0.18.0 to v0.21.0"
pr-link: https://github.com/SemiAnalysisAI/InferenceX/pull/1404

- config-keys:
- dsv4-fp4-b200-sglang
Comment on lines +2632 to +2634
Copy link
Copy Markdown
Contributor

@claude claude Bot May 17, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🔴 This PR accidentally commits a 1.5 MB / 10,883-line server.log file at the repo root (/dev/null → b/server.log in the diff) that is unrelated to the one-line SGLang image bump — its contents are actually a vLLM v0.20.0 startup log for DeepSeek-V4-Pro (PIDs, command-line args, full runtime config) with timestamps from 05-01 20:35:09. Please drop server.log from this PR, and extend .gitignore to cover server.log and gpu_metrics.csv so future runs of benchmarks/single_node/dsv4_fp4_b200.sh (which writes both to $PWD) don't re-stage the same accident.

Extended reasoning...

What is committed

The diff for this PR shows three changed files: the SGLang image bump in .github/configs/nvidia-master.yaml, the matching perf-changelog.yaml entry, and a third file — server.log — added from /dev/null. The new file is 1,517,705 bytes and 10,883 lines long. Nothing in the PR title (Update dsv4-fp4-b200-sglang SGLang image to v0.5.12-cu130) or description mentions adding a log file, and the changelog entry describes only the image bump.

Why this is clearly an accidental commit

Reading server.log it begins:

INFO 05-01 20:35:09 [__init__.py:241] Automatically detected platform cuda.
(ApiServer pid=3823850) INFO 05-01 20:35:09 [api_server.py:1839] vLLM API server version 0.20.0
...
(ApiServer_7 pid=3824147) ... model='deepseek-ai/DeepSeek-V4-Pro' ... enable_auto_tool_choice=... data_parallel_size=8 ...

So the content is a vLLM v0.20.0 startup log, not SGLang. The PR is a SGLang image-tag bump for the dsv4-fp4-b200-sglang recipe — vLLM logs have no business being in this diff. The timestamps (05-01 20:35:09) also predate the PR creation date (2026-05-17), confirming the file is a stale local artifact that got swept in by git add.

Step-by-step proof of origin

  1. benchmarks/single_node/dsv4_fp4_b200.sh line 37 sets SERVER_LOG="$PWD/server.log".
  2. The same script line 48 writes $PWD/gpu_metrics.csv via start_gpu_monitor --output.
  3. If the script is run from the repository root (a natural thing to do), both artifacts are dropped at the repo root.
  4. The current .gitignore contains only **/__pycache__/**, **/.coverage, and experimental/multiturn/vllm_benchmark/results/ — no *.log or server.log rule.
  5. A subsequent git add (e.g. git add -A or path globs that include the root) therefore stages the log, and it lands in the PR as observed.

Impact

  • Repo bloat, permanently. A 1.5 MB binary-ish blob in history is paid by every future git clone forever, even after a follow-up delete commit.
  • Leaks environment-specific runtime detail (PIDs like 3824147, hostnames, full vLLM EngineArgs dump including enable_auto_tool_choice, kv_cache_dtype, data_parallel_size, etc.) that has no audit value in version control.
  • Recurrence risk. Because .gitignore doesn't cover these files, the next contributor running the same script from the repo root will re-create the exact same accident.

How to fix

  1. git rm server.log and force-push the branch (file has never been merged, so no history rewrite of main is needed).
  2. Append to .gitignore: 
    server.log
gpu_metrics.csv
    (or, more broadly, *.log and *.csv in the benchmark output paths — author's call).

Addressing the duplicate-refutation objections

The two refutations from the verifier round flagged that bug_001 and bug_004 describe the same root cause and that only one should advance. The synthesis agent has now merged them into a single bug (merged_bug_001) — so this comment is filed once, not three times. The merged report keeps the useful concrete fix detail from bug_004 (the benchmarks/single_node/dsv4_fp4_b200.sh lines 37/48 that produce server.log and gpu_metrics.csv) while remaining a single PR comment, which is exactly what the duplicate policy asks for.

description:
- "Update SGLang image from custom deepseek-v4-blackwell@sha256:df18bfc4... (21d old) to v0.5.12-cu130"
pr-link: https://github.com/SemiAnalysisAI/InferenceX/pull/1450
Loading
Loading