[Klaud Cold] Update minimaxm2.5-fp8-b300-vllm vLLM image to v0.21.0#1454
[Klaud Cold] Update minimaxm2.5-fp8-b300-vllm vLLM image to v0.21.0#1454functionstackx wants to merge 2 commits into
Conversation
|
Thanks for the contribution! For vLLM & SGLang, please ensure that your recipes is similar to the official vLLM recipes and/or the SGLang cookbook If it is not, please create a PR first before we can merge your single node PR into the master branch. Let's ensure that the documentation is first class such that the entire ML community can benefit from your hard work! Thank you PR authors are responsible for ensuring that after merging, all GitHub Action jobs fully pass. A lot of the time, failures are just flakes and simply re-running the failed jobs will fix it. If re-running failed jobs is attempted, PR authors are responsible for ensuring it passes. See GitHub's docs on re-running failed jobs: https://docs.github.com/en/actions/how-tos/manage-workflow-runs/re-run-workflows-and-jobs#re-running-failed-jobs-in-a-workflow As a rule of thumb, generally, PR authors should request a review & get a PR approval from the respective companies' CODEOWNERS before requesting a review from core maintainers. If additional help is needed, PR authors can reach out to core maintainers over Slack. |
1 similar comment
|
Thanks for the contribution! For vLLM & SGLang, please ensure that your recipes is similar to the official vLLM recipes and/or the SGLang cookbook If it is not, please create a PR first before we can merge your single node PR into the master branch. Let's ensure that the documentation is first class such that the entire ML community can benefit from your hard work! Thank you PR authors are responsible for ensuring that after merging, all GitHub Action jobs fully pass. A lot of the time, failures are just flakes and simply re-running the failed jobs will fix it. If re-running failed jobs is attempted, PR authors are responsible for ensuring it passes. See GitHub's docs on re-running failed jobs: https://docs.github.com/en/actions/how-tos/manage-workflow-runs/re-run-workflows-and-jobs#re-running-failed-jobs-in-a-workflow As a rule of thumb, generally, PR authors should request a review & get a PR approval from the respective companies' CODEOWNERS before requesting a review from core maintainers. If additional help is needed, PR authors can reach out to core maintainers over Slack. |
|
see unofficial run visualizer at https://inferencex.semianalysis.com/inference?unofficialRun=26006185504 |
There was a problem hiding this comment.
LGTM — straightforward image bump following the established pattern; the inline nit about the stale divergence comment is non-functional.
Extended reasoning...
Overview
This PR bumps the minimaxm2.5-fp8-b300-vllm image from vllm/vllm-openai:v0.19.0-cu130 to vllm/vllm-openai:v0.21.0 in .github/configs/nvidia-master.yaml and adds a corresponding perf-changelog.yaml entry. Two-file, ~7-line mechanical change consistent with recent sibling bumps (#1404, #1394, #1416).
Security risks
None. This is a YAML config update pinning a public container image tag for benchmark runs. No code paths, secrets, auth, or permissions are touched.
Level of scrutiny
Very low. Single-line version bump in a benchmark config file, following the same pattern as multiple recently merged image-bump PRs. The full-sweep-enabled label means CI will validate the new image against the full sweep before merge.
Other factors
The bug hunter raised a single [Nit] about a stale divergence comment block (lines 4329-4332) that still references the pre-bump version delta and claims the b300-vllm entry is identical to origin/main. That is a documentation accuracy issue, not a functional bug — the YAML data itself is consistent, and the inline comment is already attached for the author to address if they want. No other concerns.
|
|
||
| minimaxm2.5-fp8-b300-vllm: | ||
| image: vllm/vllm-openai:v0.19.0-cu130 | ||
| image: vllm/vllm-openai:v0.21.0 |
There was a problem hiding this comment.
🟡 The divergence comment block at .github/configs/nvidia-master.yaml:4329-4332 becomes stale after this bump: it still claims the b300-vllm entry is 'left identical to origin/main' (no longer true) and records the divergence as 'v0.19.0-cu130 -> v0.19.1' when the actual divergence is now 'v0.21.0 -> v0.19.1' (with b300-vllm-agentic at line 4334 still pinned to v0.19.1). Either update the comment to reflect the new divergence, or reconsider whether bumping b300-vllm while leaving b300-vllm-agentic pinned is intended.
Summary
minimaxm2.5-fp8-b300-vllmfromvllm/vllm-openai:v0.19.0-cu130(26d old) tovllm/vllm-openai:v0.21.0.Test plan
full-sweep-enabledlabel.🤖 Generated with Claude Code