[Klaud Cold] Update kimik2.5-fp4-mi355x-vllm vLLM ROCm image to v0.22.0#1616
Conversation
Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
c603fc0 to
a187fa2
Compare
|
Thanks for the contribution! For vLLM & SGLang, please ensure that your recipes is similar to the official vLLM recipes and/or the SGLang cookbook If it is not, please create a PR first before we can merge your single node PR into the master branch. Let's ensure that the documentation is first class such that the entire ML community can benefit from your hard work! Thank you PR authors are responsible for ensuring that after merging, all GitHub Action jobs fully pass. A lot of the time, failures are just flakes and simply re-running the failed jobs will fix it. If re-running failed jobs is attempted, PR authors are responsible for ensuring it passes. See GitHub's docs on re-running failed jobs: https://docs.github.com/en/actions/how-tos/manage-workflow-runs/re-run-workflows-and-jobs#re-running-failed-jobs-in-a-workflow As a rule of thumb, generally, PR authors should request a review & get a PR approval from the respective companies' CODEOWNERS before requesting a review from core maintainers. If additional help is needed, PR authors can reach out to core maintainers over Slack. |
|
see unofficial run visualizer at https://inferencex.semianalysis.com/inference?unofficialRun=26696251544 |
There was a problem hiding this comment.
LGTM — straightforward image tag bump (v0.21.0 → v0.22.0) for one recipe with matching changelog entry.
Extended reasoning...
Overview
This PR bumps the vLLM ROCm image for the kimik2.5-fp4-mi355x-vllm recipe from v0.21.0 to v0.22.0 in .github/configs/amd-master.yaml, and adds the corresponding entry to perf-changelog.yaml. The change is two lines of YAML plus a six-line changelog stanza, scoped to exactly one config key.
Security risks
None. This is a benchmark-recipe image tag bump pointing to a public upstream vLLM container; it does not touch auth, crypto, permissions, secrets, or any production-serving path.
Level of scrutiny
Minimal. This is the canonical mechanical config change pattern in this repo — a single recipe's image tag is bumped to a newer upstream tagged release, the changelog reflects exactly that, and the full-sweep-enabled label means CI will run the actual recipe sweep as the functional gate.
Other factors
The bug hunting system found nothing, there are no outstanding reviewer comments to address, only the routine recipe-reminder bot comment is on the timeline, and CI sweep coverage is the right validator for an image-tag bump like this.
|
see unofficial run visualizer at https://inferencex.semianalysis.com/inference?unofficialRun=26696253037 |
|
/reuse-sweep-run |
|
see unofficial run visualizer at https://inferencex.semianalysis.com/inference?unofficialRun=26701267138 |
Summary
Update vLLM ROCm image from v0.21.0 to v0.22.0
Recipes touched:
kimik2.5-fp4-mi355x-vllmTest plan
🤖 Generated with Claude Code
Note
Low Risk
Config-only container tag bump for a single benchmark recipe; no application code or sweep matrix changes.
Overview
Bumps the MI355X fixed-seq-len benchmark recipe
kimik2.5-fp4-mi355x-vllmfromvllm/vllm-openai-rocm:v0.21.0tov0.22.0. Model (amd/Kimi-K2.5-MXFP4), runner, and TP/concurrency search space are unchanged.Adds a
perf-changelog.yamlentry documenting the image bump and linking PR #1616.Reviewed by Cursor Bugbot for commit 19c46ee. Bugbot is set up for automated code reviews on this repo. Configure here.