Skip to content

[codex] Remove perf GitHub summary#1977

Merged
cquil11 merged 1 commit into
mainfrom
codex/remove-perf-github-summary
Jul 2, 2026
Merged

[codex] Remove perf GitHub summary#1977
cquil11 merged 1 commit into
mainfrom
codex/remove-perf-github-summary

Conversation

@cquil11

@cquil11 cquil11 commented Jul 1, 2026

Copy link
Copy Markdown
Collaborator

Removes the perf results table from GitHub step summaries.

Keeps eval summaries intact.

Validation: focused tests + workflow YAML parse.

@cquil11 cquil11 marked this pull request as ready for review July 2, 2026 14:56
@cquil11 cquil11 requested a review from a team July 2, 2026 14:56
@cquil11 cquil11 merged commit 0d0327d into main Jul 2, 2026
6 checks passed
@cquil11 cquil11 deleted the codex/remove-perf-github-summary branch July 2, 2026 14:56

@claude claude Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM — clean removal of the perf step-summary path; the inlined constants and load_json in collect_eval_results.py match the deleted summarize.py verbatim, and no other callers remain.

Extended reasoning...

Overview

This PR removes the perf results markdown table from GitHub step summaries. It deletes utils/summarize.py entirely, drops the 'Print summary' step from .github/workflows/collect-results.yml, and inlines the handful of column-name constants plus the load_json helper (previously imported from summarize) directly into utils/collect_eval_results.py — its only importer. Documentation (README.md, AGENTS.md) and a couple of comment/test-name references are updated to match.

Security risks

None. This is a pure removal of a debug/reporting surface — no changes to auth, secrets, execution paths, or data handling.

Level of scrutiny

Low. This is a mechanical refactor: delete a module, inline the ~25 lines of constants and one helper into the sole consumer, and remove a step from a workflow that only wrote to $GITHUB_STEP_SUMMARY. I verified no remaining references to the deleted module (grep for utils/summarize / from summarize / import summarize turned up nothing; the other 'summarize' hit is experimental/CollectiveX/summarize.py, unrelated).

Other factors

The eval summary path (utils/collect_eval_results.py) is preserved, which matches the PR description. The test file rename (SUMMARIZE_KEYS → AGGREGATE_KEYS, test_processor_emits_required_summarize_keys → test_processor_emits_required_aggregate_keys) is cosmetic and keeps the same assertions. Bug hunter found nothing.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

Development

Successfully merging this pull request may close these issues.

1 participant