feat: add filter option to runner-model-sweep subcommand#226
Merged
Conversation
Contributor
📊 Line Count ReportFile: Total Lines: 968 Base Lines: 956 Change: +12 lines 📈 |
Contributor
There was a problem hiding this comment.
Pull Request Overview
This PR adds a --runner-node-filter argument to the runner-model-sweep subcommand, enabling developers to filter specific runner nodes by substring matching. This allows for more targeted testing of runner nodes within a runner type.
Key changes:
- Added
--runner-node-filterargument to therunner-model-sweepsubcommand CLI - Implemented filtering logic in
generate_runner_model_sweep_config()to filter runner nodes by substring match - Added comprehensive test coverage for the new filtering functionality
Reviewed Changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 2 comments.
| File | Description |
|---|---|
utils/matrix-logic/generate_sweep_configs.py |
Added CLI argument and filtering logic for runner node selection |
utils/matrix-logic/test_generate_sweep_configs.py |
Added test cases covering filter scenarios: single match, multiple matches, no matches, and default behavior |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
Contributor
📊 Line Count ReportFile: Total Lines: 968 Base Lines: 956 Change: +12 lines 📈 |
functionstackx
approved these changes
Nov 12, 2025
cquil11
added a commit
that referenced
this pull request
Nov 12, 2025
* add new mi325x scripts and configs * adding ability to filter runner node on runner-model-sweep in god file * rebase with main * Update utils/matrix-logic/generate_sweep_configs.py Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com> --------- Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adds a argument
--runner-node-filterto the subcommandrunner-model-sweepinutils/generate_sweep_configs.py.This allows developers to filter for specific runner nodes when running the
runner-model-sweepcommand.For instance, if I want to sweep across all MI325X runners, but only those that contain the string
amd, I can run the following command❯ python3 utils/matrix-logic/generate_sweep_configs.py runner-model-sweep --runner-type mi325x --runner-node-filter mi325x-amd --runner-config .github/configs/runners.yaml --config-files .github/configs/amd-master.yaml | jq length 2without filter:
❯ python3 utils/matrix-logic/generate_sweep_configs.py runner-model-sweep --runner-type mi325x --runner-config .github/configs/runners.yaml --config-files .github/configs/amd-master.yaml | jq length 10Add corresponding PyTests for this file; tests pass: