Skip to content

chore: add framework to benchmark job name#230

Merged
cquil11 merged 2 commits into
mainfrom
add-framework-to-bmk-name
Nov 13, 2025
Merged

chore: add framework to benchmark job name#230
cquil11 merged 2 commits into
mainfrom
add-framework-to-bmk-name

Conversation

@cquil11
Copy link
Copy Markdown
Collaborator

@cquil11 cquil11 commented Nov 13, 2025

Adds framework to each individual benchmark job name for increased clarity when viewing jobs in GitHub Actions UI.

@cquil11 cquil11 requested a review from a team as a code owner November 13, 2025 16:16
Copilot AI review requested due to automatic review settings November 13, 2025 16:16
Copy link
Copy Markdown
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR enhances the visibility of GitHub Actions workflow runs by adding the framework identifier to benchmark job names. This makes it easier to distinguish between different framework benchmarks when viewing the GitHub Actions UI.

  • Adds ${{ inputs.framework }} to job name templates in benchmark workflows

Reviewed Changes

Copilot reviewed 2 out of 2 changed files in this pull request and generated 1 comment.

File Description
.github/workflows/benchmark-tmpl.yml Adds framework identifier to single-node benchmark job name template
.github/workflows/benchmark-multinode-tmpl.yml Adds framework identifier to multi-node benchmark job name template

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Comment thread .github/workflows/benchmark-tmpl.yml Outdated
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
Copy link
Copy Markdown
Collaborator

@functionstackx functionstackx left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@cquil11 cquil11 merged commit 1fae268 into main Nov 13, 2025
7 checks passed
@cquil11 cquil11 deleted the add-framework-to-bmk-name branch November 13, 2025 16:58
@cquil11 cquil11 restored the add-framework-to-bmk-name branch November 13, 2025 16:58
@cquil11 cquil11 deleted the add-framework-to-bmk-name branch November 13, 2025 16:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants