chore: add perf-changelog for MI325X --exclusive flag impact#931
Merged
chore: add perf-changelog for MI325X --exclusive flag impact#931
Conversation
MI325X already has --exclusive in its salloc command. This documents the performance impact on non-TP8 configs where node sharing could cause contention. Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
Contributor
|
Thanks for the contribution! For vLLM & SGLang, please ensure that your recipes is similar to the official vLLM recipes and/or the SGLang cookbook If it is not, please create a PR first before we can merge your PR into the master branch. Let's ensure that the documentation is first class such that the entire ML community can benefit from your hard work! Thank you |
1 similar comment
Contributor
|
Thanks for the contribution! For vLLM & SGLang, please ensure that your recipes is similar to the official vLLM recipes and/or the SGLang cookbook If it is not, please create a PR first before we can merge your PR into the master branch. Let's ensure that the documentation is first class such that the entire ML community can benefit from your hard work! Thank you |
cquil11
added a commit
that referenced
this pull request
Mar 23, 2026
MI325X now has its own PR (#931). Update perf-changelog to list specific non-TP8 MI355X configs instead of wildcards. Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
cquil11
added a commit
that referenced
this pull request
Mar 23, 2026
* slurm command fix Signed-off-by: seungrokj <seungrok.jung@amd.com> * update perf changelog * add --exclusive to mi355x multinode * fix: scope PR to MI355X only, remove MI325X changes MI325X now has its own PR (#931). Update perf-changelog to list specific non-TP8 MI355X configs instead of wildcards. Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com> * chore: clarify perf-changelog description for MI355X --exclusive Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com> * Update perf-changelog.yaml --------- Signed-off-by: seungrokj <seungrok.jung@amd.com> Co-authored-by: Cam Quilici <cjquilici@gmail.com> Co-authored-by: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
--exclusivein itssalloccommandgptoss-fp4-mi325x-vllm,minimaxm2.5-fp8-mi325x-vllm)Test plan
🤖 Generated with Claude Code