Skip to content

fix(report): include party_name in account statement headers #48

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
Sendipad merged 1 commit into from
Feb 25, 2026
Merged

fix(report): include party_name in account statement headers #48

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
20 changes: 20 additions & 0 deletions uph/party/controllers/queries.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -485,6 +485,14 @@ def get_party_master_parties_db(party_master, all_roles=True, roles=None):
if not pm_roles_to_fetch:
return []

pm_names = list(set(party_master))
pm_data = frappe.get_all(
"Party Master",
filters={"name": ["in", pm_names]},
fields=["name", "party_name"],
)
pm_name_map = {d.name: d.party_name for d in pm_data}

all_parties = []
from uph.party.utils import get_party_type_currency_field

Expand All @@ -509,6 +517,7 @@ def get_party_master_parties_db(party_master, all_roles=True, roles=None):
)
for p in found:
p["party_type"] = role_doctype
p["party_name"] = pm_name_map.get(p.party_master)
all_parties.extend(found)
except Exception:
frappe.log_error(
Expand All @@ -532,6 +541,16 @@ def get_party_master_parties_db(party_master, all_roles=True, roles=None):
if not pm_roles:
return []

if fetch_all:
pm_data = frappe.get_all("Party Master", fields=["name", "party_name"])
else:
pm_data = frappe.get_all(
"Party Master",
filters={"name": party_master},
fields=["name", "party_name"],
)
pm_name_map = {d.name: d.party_name for d in pm_data}

parties = []
from uph.party.utils import get_party_type_currency_field

Expand Down Expand Up @@ -559,6 +578,7 @@ def get_party_master_parties_db(party_master, all_roles=True, roles=None):
)
for p in found:
p["party_type"] = role_doctype
p["party_name"] = pm_name_map.get(p.party_master)
parties.append(p)
except Exception:
frappe.log_error(
Expand Down