Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Motivation
Party Masterwhen setup templates may intentionally create multiple roots.frappe.get_meta()misuse.Description
docs/codebase_audit.mdwith audit notes and recommendations about which bootstraps belong to migrate vs install flows.include_schema_ddlflag to_safe_setup_operations()and call it withFalsefrom install paths andTruefromon_migrate()to ensurecreate_custom_indices()runs only during migrate/patch flows.create_gender_fixtures()to test or developer mode by checkingfrappe.flags.in_testorfrappe.conf.get("developer_mode").create_custom_indices()to usecustomerforSales InvoiceandsupplierforPurchase Invoice, verify existence of all referenced columns, quote column names in generated DDL, and log errors on failure.create_party_master_tree()tolerant of multi-root setups by only bootstrapping a fallback root when no roots exist and normalize an existing1000record when present.PartyMasterSettings.validate_document_types()to requiredocument_typewith a row-specific error message and streamline parent/child validation logic.Testing
bench run-tests/ unit tests) and the tests completed successfully.Party Mastercreation and index creation logging, all of which passed.