Fix clone stats workflow writing wrong file path#69
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Motivation
stats/clones.jsonbut previously wroteclones.jsonto the repository root, causingfatal: pathspec 'stats/clones.json' did not match any files.Description
.github/workflows/clone-stats.ymlso the Extract step creates thestatsdirectory and writes the JSON tostats/clones.jsoninstead of the repo root.mkdir -p statsbefore writing to guarantee the directory exists.Testing
echo '{"count": 12}' > traffic.json && COUNT=$(jq '.count' traffic.json) && mkdir -p stats && echo "{ \"count\": $COUNT }" > stats/clones.json && cat stats/clones.json, which produced the expected JSON payload and file path.git statusand committed the workflow change withgit add .github/workflows/clone-stats.yml && git commit -m "Fix clone stats workflow output path", which succeeded.mkdir -p statsand targetstats/clones.jsonupdates and that no tests or other CI steps were broken by this change.Codex Task