fix(ci): use JSON coverage export instead of fragile text parsing#7
Merged
balloob merged 1 commit intoSendspin:mainfrom Apr 15, 2026
Merged
fix(ci): use JSON coverage export instead of fragile text parsing#7balloob merged 1 commit intoSendspin:mainfrom
balloob merged 1 commit intoSendspin:mainfrom
Conversation
The previous approach parsed llvm-cov's text table with awk to extract coverage percentages. This broke because $NF (last field) picked up the branch coverage column which is "-" when no branches exist, causing bc to fail with "bad expression". Replace with llvm-cov export -format=text -summary-only which produces structured JSON. Coverage percentages are extracted with python3 from data[0].totals.lines.percent — no awk, no column counting, no fragility across toolchain versions. Also refactors the workflow to locate the test binary and profdata once in a dedicated step, avoiding repeated find commands across steps. Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The previous approach parsed llvm-cov's text table with awk to extract coverage percentages. This broke because $NF (last field) picked up the branch coverage column which is "-" when no branches exist, causing bc to fail with "bad expression".
Replace with llvm-cov export -format=text -summary-only which produces structured JSON. Coverage percentages are extracted with python3 from data[0].totals.lines.percent — no awk, no column counting, no fragility across toolchain versions.
Also refactors the workflow to locate the test binary and profdata once in a dedicated step, avoiding repeated find commands across steps.