Add server-initiated-volume-curve scenario (#64)#72
Closed
balloob wants to merge 1 commit into
Closed
Conversation
Adds the volume calibration scenario from #64. Per the audit, sendspin-go and sendspin-js apply linear `vol/100` gain instead of the spec's implied `(vol/100)^1.5` perceptual curve. A multi-room group containing one go/js player and one rs/SendspinKit/cli player has an audible loudness mismatch at any volume below 100. `volume-perceptual-curve` is declared on the aiosendspin server only. Every client case fails fast until each adapter declares the capability based on the SDK's exposed surface.
Collaborator
Author
|
Closing per discussion in #68 — dropping scaffolding-only scenarios in favor of real end-to-end tests as SDK surface lands. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
server-initiated-volume-curvescenario from Sendspin/conformance#64 to the matrixvolume-perceptual-curveon the aiosendspin server onlyNotes
vol/100gain instead of the spec's implied(vol/100)^1.5perceptual curve. A multi-room group containing one go/js player and one rs/SendspinKit/cli player has an audible loudness mismatch at any volume below 100.Test plan
python -m compileall src scriptspython -m conformance.cli run --results-dir results --from aiosendspin --to aiosendspin --timeout-seconds 25shows the new scenario row with the expected fail-fast reason