Fix dev scripts to use uv properly#182
Merged
maximmaxim345 merged 2 commits intomainfrom Mar 12, 2026
Merged
Conversation
Replace manual venv creation and pip installs with `uv sync --extra test`. Remove reference to nonexistent `[cli]` extra.
Contributor
There was a problem hiding this comment.
Pull request overview
Updates developer helper scripts to use uv consistently, aligning local setup/execution with the project’s uv-based workflow and avoiding accidental use of globally installed sendspin.
Changes:
- Replace manual venv/pip install flow in
scripts/setup.shwithuv sync --extra test. - Update
scripts/sendspinto run the project viauv runfrom the repo root.
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 1 comment.
| File | Description |
|---|---|
| scripts/setup.sh | Switches dev dependency setup to uv sync and installs pre-commit hooks via uv run. |
| scripts/sendspin | Runs sendspin through uv run from the git toplevel instead of python -m ... via run-in-env.sh. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fix
scripts/setup.shby usinguv syncto match the aiosendspin setup script.Also fixes
scripts/sendspinthat ranpython -m sendspin.cliviarun-in-env.sh, which could pick up a globally installed version instead of the local dev checkout.