Conversation
Snawoot
force-pushed
the
mmdb
branch
4 times, most recently
from
103f5ed to
72a1329
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Purpose of proposed changes
Introduces native access to MMDB databases from JS scripts, saving users from jumping over hoops in order to use any kind of GeoIP database.
Essential steps taken
Implemented dynamic JS object which serves as a proxy to MMDB reader. Lifecycle of underlying reader is tied to garbage collection of the JS wrapper. Mapping between objects is left to MMDB reader and JS runtime implementation, our wrapper knows nothing about DB structure.