refactor: extract composables from UI for testability#36
Merged
Conversation
- Add Ollama client for on-device LLM inference (qwen2.5-coder, nomic-embed-text) - Add NL-to-SQL translation for natural language queries - Add document ingestion pipeline (CSV/MD/JSON/TXT chunking) - Add ModelSettings component for model management - Add 263 Vitest tests with 46% coverage (app, api, nl-to-sensibleql, components) - Fix jsdom ESM compatibility by switching to happy-dom
- Extract useCodeMirror from SensibleQLEditor (CodeMirror wrapper) - Extract useGraphData + useForceSimulation from GraphView - Extract useAppInit + useKeyboardShortcuts from App - Extract useReportGenerator from ReportView - Add tests for all new composables 297 tests passing, 41% coverage, lib/ now at 67%
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Refactor 3 UI components to enable testing:
Changes
New Composables (src/lib/)
Test Results
This enables testing of business logic separated from UI rendering.